Page MenuHomeFreeBSD

Enable NVME option (nvmecontrol, etc) on aarch64
ClosedPublic

Authored by greg_unrelenting.technology on Aug 6 2019, 1:30 PM.

Details

Summary

NVMe itself works fine on aarch64, let's install nvmecontrol and whatever else the option enables.

Test Plan

nvmecontrol builds and runs. I don't currently have an adapter from M.2 to full PCIe (nor an SSD that's already in PCIe form factor) though. I guess it's possible to test with the virtual NVMe drive in AWS EC2 haha.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

imp accepted this revision.Aug 6 2019, 5:51 PM

Have you run this and does it work?
Assuming yes, this is a good change.

This revision is now accepted and ready to land.Aug 6 2019, 5:51 PM
In D21168#460060, @imp wrote:

Have you run this and does it work?

As I mentioned

nvmecontrol builds and runs

but I don't have an aarch64 system with a real NVMe drive to do anything interesting with it.

imp added a comment.Aug 7 2019, 12:00 AM
In D21168#460060, @imp wrote:

Have you run this and does it work?

As I mentioned

nvmecontrol builds and runs

but I don't have an aarch64 system with a real NVMe drive to do anything interesting with it.

OK. Does the kernel at least build? If so, I'll push this in if we've not punished you with a commit bit yet :)

imp added a comment.Aug 7 2019, 12:03 AM
In D21168#460154, @imp wrote:
In D21168#460060, @imp wrote:

Have you run this and does it work?

As I mentioned

nvmecontrol builds and runs

but I don't have an aarch64 system with a real NVMe drive to do anything interesting with it.

OK. Does the kernel at least build? If so, I'll push this in if we've not punished you with a commit bit yet :)

actually, scratch that. I'll push this in if it passes a buildworld I've just started.

This revision was automatically updated to reflect the committed changes.