Page MenuHomeFreeBSD

Add a CXXWARNFLAGS variable
ClosedPublic

Authored by asomers on Jul 30 2019, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 11:28 AM
Unknown Object (File)
Oct 19 2024, 6:00 PM
Unknown Object (File)
Oct 1 2024, 4:14 PM
Unknown Object (File)
Sep 14 2024, 12:19 PM
Unknown Object (File)
Sep 2 2024, 12:58 AM
Unknown Object (File)
Sep 1 2024, 4:58 AM
Unknown Object (File)
Sep 1 2024, 4:51 AM
Unknown Object (File)
Aug 30 2024, 4:41 PM

Details

Summary

Add a CXXWARNFLAGS variable

Some warning flags are valid for C++ but not C. GCC 8 complains if you pass
such flags when building a C file. Using a separate variable for these
flags allows building both C and C++ files in the same directory (such as
the fusefs tests) under GCC.

Test Plan

Tested with riscv64-unknown-freebsd13.0-g++ 8.1.0 and the fusefs
tests

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems fine to me.

Previously you tried C++-only flags in CFLAGS in the fuse tests?

Seems fine to me.

Previously you tried C++-only flags in CFLAGS in the fuse tests?

Yes. Neither Clang nor GCC 6 complained, but GCC 8 does. See https://svnweb.freebsd.org/base/projects/fuse2/tests/sys/fs/fusefs/Makefile?revision=350163&view=markup#l68 .

This revision is now accepted and ready to land.Jul 30 2019, 7:23 PM
This revision was automatically updated to reflect the committed changes.