Page MenuHomeFreeBSD

Add a CXXWARNFLAGS variable
ClosedPublic

Authored by asomers on Jul 30 2019, 4:52 PM.
Tags
None
Referenced Files
F132295615: D21116.id60305.diff
Wed, Oct 15, 3:17 PM
F132295610: D21116.id60295.diff
Wed, Oct 15, 3:17 PM
F132248265: D21116.id60295.diff
Wed, Oct 15, 4:24 AM
F132248259: D21116.id60305.diff
Wed, Oct 15, 4:24 AM
F132248241: D21116.id.diff
Wed, Oct 15, 4:23 AM
Unknown Object (File)
Tue, Oct 14, 6:55 PM
Unknown Object (File)
Mon, Sep 29, 11:11 AM
Unknown Object (File)
Sun, Sep 28, 3:01 AM

Details

Summary

Add a CXXWARNFLAGS variable

Some warning flags are valid for C++ but not C. GCC 8 complains if you pass
such flags when building a C file. Using a separate variable for these
flags allows building both C and C++ files in the same directory (such as
the fusefs tests) under GCC.

Test Plan

Tested with riscv64-unknown-freebsd13.0-g++ 8.1.0 and the fusefs
tests

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems fine to me.

Previously you tried C++-only flags in CFLAGS in the fuse tests?

Seems fine to me.

Previously you tried C++-only flags in CFLAGS in the fuse tests?

Yes. Neither Clang nor GCC 6 complained, but GCC 8 does. See https://svnweb.freebsd.org/base/projects/fuse2/tests/sys/fs/fusefs/Makefile?revision=350163&view=markup#l68 .

This revision is now accepted and ready to land.Jul 30 2019, 7:23 PM
This revision was automatically updated to reflect the committed changes.