Implement a devtype command.
ClosedPublic
Actions

Authored by imp on Jul 15 2019, 6:26 AM.

Details

Reviewers

ken
scottl
mav
rpokala

Group Reviewers

manpages

Commits

rS350018: Implement a devtype command.

Summary

Implement a devtype command.

List the device's protocol. The returned value is one of the following:
        ata     direct attach ATA or SATA device
        satl    a SATA device attached via SAS
        scsi    A parallel SCSI or SAS
        nvme    A direct attached NVMe device
        mmcsd   A MMC or SD attached device

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 15 2019, 6:26 AM

Harbormaster completed remote builds in B25343: Diff 59749.Jul 15 2019, 6:26 AM

imp added reviewers: ken, scottl, mav.Jul 15 2019, 6:26 AM

val_packett.cool added a subscriber: val_packett.cool.Jul 15 2019, 11:24 AM

val_packett.cool added inline comments.

sbin/camcontrol/camcontrol.8
2534 ↗	(On Diff #59749)	The wording is a bit funny, device attached via device… Maybe "attached via an SD/MMC controller"?

scottl added inline comments.Jul 15 2019, 1:40 PM

sbin/camcontrol/camcontrol.8
2527 ↗	(On Diff #59749)	The term `sat` or `satl` is a more mainstream term here. I know that the `CC_DT_ATA_BEHIND_SCSI` name already exists, but for user-facing functionality, let's do it differently (and I wouldn't mind if the CC_DT name changed also).
2538 ↗	(On Diff #59749)	Something to consider would be a `raid` devtype, since there are a fair number of drivers that have devices of this type.
sbin/camcontrol/camcontrol.c
271 ↗	(On Diff #59749)	Use `satl` here.

imp added inline comments.Jul 15 2019, 4:19 PM

sbin/camcontrol/camcontrol.8
2527 ↗	(On Diff #59749)	I'll go with satl and move these changes through.
2534 ↗	(On Diff #59749)	It's from the department of redundancy department. I'll fix their incursion into my work.
2538 ↗	(On Diff #59749)	What distinguishes this? all the other things are basically a protocol level thing, while this I'm unsure how to implement.
sbin/camcontrol/camcontrol.c
271 ↗	(On Diff #59749)	will do

updates from scott's comments

Harbormaster completed remote builds in B25354: Diff 59781.Jul 15 2019, 8:44 PM

imp edited the summary of this revision. (Show Details)Jul 15 2019, 8:44 PM

imp marked 4 inline comments as done.

imp added inline comments.

sbin/camcontrol/camcontrol.8
2538 ↗	(On Diff #59749)	I'll add 'raid' in the future once we get sorted out what that means.

rpokala added a subscriber: rpokala.Jul 15 2019, 8:57 PM

rpokala added inline comments.

sbin/camcontrol/camcontrol.8
2523 ↗	(On Diff #59781)	I haven't looked at the larger context of this manpage, but shouldn't `cam` be at least capitalized, if not flagged as an acronym?
2528 ↗	(On Diff #59781)	Perhaps spell out `SCSI-ATA Translation Layer` here?
2540 ↗	(On Diff #59781)	s/Some crazy/An unexpected/ #professional ;-)