Page MenuHomeFreeBSD
Differential D20894

Correct definitions in sys.opencrypto.runtests.main for 32bit platform
ClosedPublic
Actions

Authored by lwhsu on Jul 9 2019, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 23, 6:02 PM
Unknown Object (File)
Sun, Sep 20, 1:23 AM
Unknown Object (File)
Sat, Sep 19, 10:10 PM
Unknown Object (File)
Sat, Sep 19, 9:39 PM
Unknown Object (File)
Sat, Sep 19, 7:42 PM
Unknown Object (File)
Fri, Sep 11, 5:45 PM
Unknown Object (File)
Thu, Sep 10, 11:30 PM
Unknown Object (File)
Tue, Sep 8, 4:53 AM
View All Files
Subscribers
imp

Details

Reviewers
asomers
cem
jhb
jmg
ngie
Commits
rS350209: MFC r346431, r349872
rS350164: MFC r349872:
rS349872: Correct definitions in sys.opencrypto.runtests.main for 32bit platform
Summary

sys.opencrypto.runtests.main tests are always failing on 32bit platform,
correct these definitions from sys/opencrypto/cryptodev.h .

Test Plan

cd /usr/tests/sys/opencrypto/ && kyua test

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lwhsu created this revision.Jul 9 2019, 4:55 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 9 2019, 4:55 PM
Harbormaster completed remote builds in B25267: Diff 59574.Jul 9 2019, 4:55 PM
cem accepted this revision.Jul 9 2019, 4:58 PM

No objection.

This revision is now accepted and ready to land.Jul 9 2019, 4:58 PM
jhb accepted this revision.Jul 9 2019, 7:11 PM

Nice. I was just planning on looking why these tests fail on i386. Thanks!

Closed by commit rS349872: Correct definitions in sys.opencrypto.runtests.main for 32bit platform (authored by lwhsu). · Explain WhyJul 10 2019, 1:08 AM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rS349872: Correct definitions in sys.opencrypto.runtests.main for 32bit platform.
ngie added a comment.Jul 10 2019, 5:02 AM

This should actually be obtained via ctypes.

lwhsu added a comment.Jul 16 2019, 7:41 AM
In D20894#452944, @ngie wrote:

This should actually be obtained via ctypes.

It will be great if this is possible. I wanted to check how to do so but I don't have much time on it right now. If you can point me some example, I can fix this soon. Thanks!

lwhsu added a commit: rS350164: MFC r349872:.Jul 20 2019, 7:04 AM
lwhsu added a commit: rS350209: MFC r346431, r349872.Jul 22 2019, 8:27 AM

Revision Contents
Changeset List

PathSize
head/
tests/
sys/
opencrypto/
12 lines

Diff 59592

View Options

head/tests/sys/opencrypto/cryptodev.py

Loading...