Differential D20857

[PPC64] pseries: fix realmaxaddr calculation
ClosedPublic
Actions

Authored by luporl on Jul 4 2019, 7:07 PM.

Tags

None

Referenced Files

	F136287423: D20857.id59598.diff
	Mon, Nov 17, 1:13 AM

	Unknown Object (File)
	Sun, Nov 16, 10:43 PM

	Unknown Object (File)
	Sun, Nov 16, 8:19 PM

	Unknown Object (File)
	Sun, Nov 16, 5:14 PM

	Unknown Object (File)
	Sun, Nov 16, 5:04 PM

	Unknown Object (File)
	Sun, Nov 16, 12:20 PM

	Unknown Object (File)
	Sun, Nov 16, 11:42 AM

	Unknown Object (File)
	Sun, Oct 26, 3:48 PM

Subscribers

Details

Reviewers

jhibbits
bdragon
nwhitehorn

Commits

rS349885: [PPC64] pseries: fix realmaxaddr calculation

Summary

On POWER9/pseries, QEMU passes several regions of memory,
instead of a single region containing all memory, as the
code was expecting.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

luporl created this revision.Jul 4 2019, 7:07 PM

Harbormaster completed remote builds in B25202: Diff 59405.Jul 4 2019, 7:07 PM

Makes sense to me. That's the same sort of thing that chrp_mem_regions() is doing to determine it for its own purposes.

Looks good overall. Just a couple nits..

sys/powerpc/aim/slb.c
419 ↗	(On Diff #59405)	This looks to be a different patch altogether. I don't think it belongs in this change.
sys/powerpc/pseries/platform_chrp.c
151 ↗	(On Diff #59405)	realmaxaddr = MAX(off, realmaxaddr) should do the same thing.

luporl added inline comments.Jul 8 2019, 12:34 PM

sys/powerpc/aim/slb.c
419 ↗	(On Diff #59405)	Ok, I'll commit this part separately.
sys/powerpc/pseries/platform_chrp.c
151 ↗	(On Diff #59405)	Right, I'll change this part to use MAX.

Addressed jhibbits' comments

Harbormaster completed remote builds in B25244: Diff 59533.Jul 8 2019, 12:40 PM

luporl marked 2 inline comments as done.Jul 8 2019, 12:41 PM

jhibbits accepted this revision.Jul 8 2019, 4:24 PM

This revision is now accepted and ready to land.Jul 8 2019, 4:24 PM

Closed by commit rS349885: [PPC64] pseries: fix realmaxaddr calculation (authored by luporl). · Explain WhyJul 10 2019, 1:36 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS349885: [PPC64] pseries: fix realmaxaddr calculation.

Herald added a subscriber: imp. · View Herald TranscriptJul 10 2019, 1:36 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

pseries/

platform_chrp.c

9 lines

Diff 59598

head/sys/powerpc/pseries/platform_chrp.c

Loading...