Page MenuHomeFreeBSD

[PPC64] pseries: fix realmaxaddr calculation
ClosedPublic

Authored by luporl on Jul 4 2019, 7:07 PM.

Details

Summary

On POWER9/pseries, QEMU passes several regions of memory,
instead of a single region containing all memory, as the
code was expecting.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

luporl created this revision.Jul 4 2019, 7:07 PM

Makes sense to me. That's the same sort of thing that chrp_mem_regions() is doing to determine it for its own purposes.

Looks good overall. Just a couple nits..

sys/powerpc/aim/slb.c
419 ↗(On Diff #59405)

This looks to be a different patch altogether. I don't think it belongs in this change.

sys/powerpc/pseries/platform_chrp.c
151 ↗(On Diff #59405)

realmaxaddr = MAX(off, realmaxaddr) should do the same thing.

luporl added inline comments.Jul 8 2019, 12:34 PM
sys/powerpc/aim/slb.c
419 ↗(On Diff #59405)

Ok, I'll commit this part separately.

sys/powerpc/pseries/platform_chrp.c
151 ↗(On Diff #59405)

Right, I'll change this part to use MAX.

luporl updated this revision to Diff 59533.Jul 8 2019, 12:40 PM
luporl edited the summary of this revision. (Show Details)
  • Addressed jhibbits' comments
luporl marked 2 inline comments as done.Jul 8 2019, 12:41 PM
jhibbits accepted this revision.Jul 8 2019, 4:24 PM
This revision is now accepted and ready to land.Jul 8 2019, 4:24 PM
This revision was automatically updated to reflect the committed changes.