Page MenuHomeFreeBSD

lang/rust: add powerpc64 ELFv2 support
ClosedPublic

Authored by mikael.urankar_gmail.com on Jun 28 2019, 1:59 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich added a subscriber: jbeich.Jun 28 2019, 2:59 PM
jbeich added inline comments.
lang/rust/Makefile
151 ↗(On Diff #59155)

Did you mean > and not >=? If so 1300036 users may end up using Clang but not ELFv2.

156 ↗(On Diff #59155)

None of rustc --print target-list currently have OS version. Did you check ports depending on lang/rust build fine?

jbeich added inline comments.Jun 28 2019, 3:01 PM
lang/rust/Makefile
156 ↗(On Diff #59155)

Nevermind. I didn't notice this target is for LLVM.

need to fix osversion, distinfo, Uses/cargo.mk

lang/rust/Makefile
151 ↗(On Diff #59155)

yes, it should be >=

156 ↗(On Diff #59155)

I tried devel/bingrep, it works fine.

mikael.urankar_gmail.com edited the summary of this revision. (Show Details)

I did a

svn mv patch-src_librustc__llvm_build.rs extra-patch-ppc64-gcc

but it doesn't translate well in the diff, what is the correct way to do it?

mikael.urankar_gmail.com retitled this revision from lang/rust: WIP add powerpc64 ELFv2 support to lang/rust: add powerpc64 ELFv2 support.
mikael.urankar_gmail.com edited the summary of this revision. (Show Details)
mikael.urankar_gmail.com edited reviewers, added: rust; removed: portmgr.
tobik requested changes to this revision.Oct 16 2019, 9:07 AM
tobik added a subscriber: tobik.
tobik added inline comments.
lang/rust/Makefile
70 ↗(On Diff #63311)

Please just use -${PPC_ABI:tl} and revert the distinfo changes. The bootstrap tarball filenames are all lowercase. Let's keep it that way.

91 ↗(On Diff #63311)

EXTRA_PATCHES+=

138–144 ↗(On Diff #63311)

It sure feels like this (and extra-patch-ppc64-gcc) should be some cfg! or env! thing in Rust rather than us wrangling with conditional patches, but not sure how that would work exactly. It's fine for now I guess.

256–258 ↗(On Diff #63311)

Best add PPC_ABI=ELFv1 here so that makesum can still work as it should on every arch.

265 ↗(On Diff #63311)

Replace BOOTSTRAPS_SUFFIX with PPC_ABI=ELFv2.

266–267 ↗(On Diff #63311)

Revert these too.

This revision now requires changes to proceed.Oct 16 2019, 9:07 AM
tobik updated this revision to Diff 64047.Nov 7 2019, 6:10 PM
tobik accepted this revision.Nov 7 2019, 6:19 PM
This revision is now accepted and ready to land.Nov 7 2019, 6:19 PM