in_mcast.c: need if_addr_lock around inm_release_deferred
ClosedPublic
Actions

Authored by rlibby on Jun 24 2019, 4:28 PM.

Details

Reviewers

glebius
• hselasky

Commits

rS355103: in_mcast.c: need if_addr_lock around inm_release_deferred

Summary

Apply a similar fix as for in6_mcast.c.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25003
Build 23718: arc lint + arc unit

Event Timeline

rlibby created this revision.Jun 24 2019, 4:28 PM

Harbormaster completed remote builds in B25003: Diff 58952.Jun 24 2019, 4:28 PM

Fix up for conflict with r349369.

Harbormaster completed remote builds in B25154: Diff 59265.Jul 1 2019, 4:04 PM

rlibby added a subscriber: • hselasky.Jul 1 2019, 4:08 PM

Patch looks good to me. Did you run with this patch?

rlibby mentioned this in D20739: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked.Jul 2 2019, 4:20 PM

In D20740#451134, @hselasky wrote:

Patch looks good to me. Did you run with this patch?

Finally got around to testing this. I have been running with this patch, but wanted to demonstrate that the error paths were actually covered.

I was able to hit the first path (in in_joingroup_locked()) with an alloc M_NOWAIT fail point. I think the second one (in in_join_group()) is not possible to hit with the current code flow (is_new && imf → imf->imf_inm == NULL). But I inserted a fail point between in_joingroup_locked() and inm_acquire() and was able to light it up that way. No panics or witness warnings.