Page MenuHomeFreeBSD
Differential D20740

in_mcast.c: need if_addr_lock around inm_release_deferred
ClosedPublic
Actions

Authored by rlibby on Jun 24 2019, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:47 PM
Unknown Object (File)
Nov 25 2024, 10:37 AM
Unknown Object (File)
Nov 18 2024, 10:33 PM
Unknown Object (File)
Oct 28 2024, 5:14 PM
Unknown Object (File)
Oct 28 2024, 5:14 PM
Unknown Object (File)
Oct 28 2024, 5:14 PM
Unknown Object (File)
Oct 28 2024, 5:14 PM
Unknown Object (File)
Oct 28 2024, 5:00 PM
View All 56 Files
Subscribers
• hselasky
imp
mmacy
shurd

Details

Reviewers
glebius
• hselasky
Commits
rS355103: in_mcast.c: need if_addr_lock around inm_release_deferred
Summary

Apply a similar fix as for in6_mcast.c.

Sponsored by: Dell EMC Isilon

Test Plan

sysctl debug.fail_point.mnowait="1%return"
kyua test -k /usr/tests/sys/Kyuafile

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby created this revision.Jun 24 2019, 4:28 PM
Harbormaster completed remote builds in B25003: Diff 58952.Jun 24 2019, 4:28 PM
rlibby updated this revision to Diff 59265.Jul 1 2019, 4:04 PM

Fix up for conflict with r349369.

Harbormaster completed remote builds in B25154: Diff 59265.Jul 1 2019, 4:04 PM
rlibby added a subscriber: • hselasky.Jul 1 2019, 4:08 PM
• hselasky added a comment.Jul 2 2019, 2:16 PM

Patch looks good to me. Did you run with this patch?

rlibby mentioned this in D20739: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked.Jul 2 2019, 4:20 PM
rlibby added a comment.Nov 25 2019, 9:29 PM
In D20740#451134, @hselasky wrote:

Patch looks good to me. Did you run with this patch?

Finally got around to testing this. I have been running with this patch, but wanted to demonstrate that the error paths were actually covered.

I was able to hit the first path (in in_joingroup_locked()) with an alloc M_NOWAIT fail point. I think the second one (in in_join_group()) is not possible to hit with the current code flow (is_new && imf → imf->imf_inm == NULL). But I inserted a fail point between in_joingroup_locked() and inm_acquire() and was able to light it up that way. No panics or witness warnings.

• hselasky accepted this revision.Nov 25 2019, 9:49 PM
This revision is now accepted and ready to land.Nov 25 2019, 9:49 PM
Closed by commit rS355103: in_mcast.c: need if_addr_lock around inm_release_deferred (authored by rlibby). · Explain WhyNov 25 2019, 10:25 PM
This revision was automatically updated to reflect the committed changes.
rlibby added a commit: rS355103: in_mcast.c: need if_addr_lock around inm_release_deferred.
Herald added a subscriber: imp. · View Herald TranscriptNov 25 2019, 10:25 PM

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
4 lines

Diff 64871

View Options

head/sys/netinet/in_mcast.c

Loading...