Page MenuHomeFreeBSD

in_mcast.c: need if_addr_lock around inm_release_deferred
ClosedPublic

Authored by rlibby on Jun 24 2019, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 8:55 PM
Unknown Object (File)
Feb 8 2024, 6:57 PM
Unknown Object (File)
Feb 5 2024, 4:02 PM
Unknown Object (File)
Dec 20 2023, 6:43 AM
Unknown Object (File)
Nov 20 2023, 4:53 AM
Unknown Object (File)
Nov 12 2023, 10:08 PM
Unknown Object (File)
Nov 9 2023, 11:33 AM
Unknown Object (File)
Nov 1 2023, 8:30 AM

Details

Summary

Apply a similar fix as for in6_mcast.c.

Sponsored by: Dell EMC Isilon

Test Plan

sysctl debug.fail_point.mnowait="1%return"
kyua test -k /usr/tests/sys/Kyuafile

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fix up for conflict with r349369.

Patch looks good to me. Did you run with this patch?

Patch looks good to me. Did you run with this patch?

Finally got around to testing this. I have been running with this patch, but wanted to demonstrate that the error paths were actually covered.

I was able to hit the first path (in in_joingroup_locked()) with an alloc M_NOWAIT fail point. I think the second one (in in_join_group()) is not possible to hit with the current code flow (is_new && imfimf->imf_inm == NULL). But I inserted a fail point between in_joingroup_locked() and inm_acquire() and was able to light it up that way. No panics or witness warnings.

This revision is now accepted and ready to land.Nov 25 2019, 9:49 PM