Differential D20642

efinet: Defer exclusively opening the network handles
ClosedPublic
Actions

Authored by scottph on Jun 14 2019, 8:53 PM.

Details

Reviewers

bcran
scottph
imp
tsoome
emaste
kevans

Commits

rS349201: efinet: Defer exclusively opening the network handles

Summary

Don't commit to exclusive access to the network device handle by
efinet until the loader has decided to load something through the
network. This allows for the possibility of other users of the
network device.

Test Plan

Do UEFI PXE, see that it continues to work.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

scottph created this revision.Jun 14 2019, 8:53 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 14 2019, 8:53 PM

scottph added a child revision: D20643: loader: add HTTP support using UEFI.Jun 14 2019, 8:55 PM

bcran added reviewers: scottph, imp, tsoome, emaste, kevans.Jun 14 2019, 9:12 PM

lwhsu added a subscriber: lwhsu.Jun 16 2019, 2:03 PM

also chain /boot/loader.efi does not complain about network any more. network boot seems to be all ok too.

This revision is now accepted and ready to land.Jun 19 2019, 8:07 AM

Mentor approval for commit.

You can add a "Tested by: tsoome", or probably "Tested by: bcran, tsoome"

Closed by commit rS349201: efinet: Defer exclusively opening the network handles (authored by bcran). · Explain WhyJun 19 2019, 6:47 PM

This revision was automatically updated to reflect the committed changes.

bcran added a commit: rS349201: efinet: Defer exclusively opening the network handles.

Revision Contents
Changeset List

Path

Size

head/

stand/

efi/

libefi/

efinet.c

32 lines

Diff 58800

View Options

head/stand/efi/libefi/efinet.c

efinet: Defer exclusively opening the network handlesClosedPublicActions