readelf: Make -t imply -S, for compatibility with GNU binutils.
ClosedPublic
Actions

Authored by markj on May 30 2019, 6:35 PM.

Details

Reviewers

emaste
jhb
jkoshy_users.sourceforge.net
kaiw

Group Reviewers

manpages

Commits

rS348443: readelf: Make -t imply -S, for compatibility with GNU binutils.

Test Plan

elftoolchain readelf and binutils readelf produce identical formating for readelf -St /lib/libc.so.7.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 30 2019, 6:35 PM

Harbormaster completed remote builds in B24607: Diff 58083.May 30 2019, 6:35 PM

markj added reviewers: emaste, jhb, jkoshy_users.sourceforge.net, kaiw.May 30 2019, 6:35 PM

emaste accepted this revision.May 30 2019, 6:39 PM

This revision is now accepted and ready to land.May 30 2019, 6:39 PM

markj edited the test plan for this revision. (Show Details)May 30 2019, 6:40 PM

elftoolchain readelf and binutils readelf produce identical formating for readelf -St /lib/libc.so.7.

presumably you want to compare readelf -t too :)

In D20475#441968, @emaste wrote:

presumably you want to compare readelf -t too :)

Oh, rather that readelf -t is identical to readelf -St? OK

In D20475#441969, @emaste wrote:

In D20475#441968, @emaste wrote:

presumably you want to compare readelf -t too :)

Oh, rather that readelf -t is identical to readelf -St? OK

Yeah. readelf -t produces the same output now, modulo the fact the elftoolchain uses slightly different section names: SUNW_versym instead of VERSYM, SUNW_verdef instead of VERDEF.

Closed by commit rS348443: readelf: Make -t imply -S, for compatibility with GNU binutils. (authored by markj). · Explain WhyMay 30 2019, 6:54 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: manpages. · View Herald TranscriptMay 30 2019, 6:54 PM

Herald added a subscriber: imp. · View Herald Transcript

dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM