Add support for USB 3.0 XHCI via ACPI

[val_packett.cool]

Summary

Ampere eMAG systems have XHCI just descibed in ACPI, not on PCI.

Test Plan

Original version tested on Ampere eMAG by Tuan Phan <[e-mail]>

[emaste]

Patch looks plausible to me, @manu or @andrew can you review and commit?
PR 237055

[manu]

Something like D19389 would be better.

[emaste]

In D19986#430466, @manu wrote:

Something like D19389 would be better.

Ah, yes. GregV would you rework it using that approach?

[val_packett.cool]

In D19986#430964, @emaste wrote:

In D19986#430466, @manu wrote:

Something like D19389 would be better.

Ah, yes. GregV would you rework it using that approach?

yeah, sure. I forgot about that one (even though I wrote a comment there) and I was looking at sys/dev/ahci/ahci_generic.c instead :)

[val_packett.cool]

Done. btw, the original version was confirmed working on the Ampere system.

[andrew]

sys/dev/usb/controller/generic_xhci_fdt.c

33–50 ↗

(On Diff #56658)

Do we need all these headers in the attachment code?

97 ↗

(On Diff #56658)

This should be
return (generic_xhci_attach(dev));

[emaste]

As with GregV's report in PR237055 dsdt has for USB:

Method (_STA, 0, NotSerialized)  // _STA: Status
{
    Return (0x00)
}

regardless of BIOS settings; I wasn't able to test this here.

[manu]

The fdt needs it's own detach function where we disable the phy (like it's done in D19389 for ehci).

[manu]

In D19986#431905, @manu wrote:

The fdt needs it's own detach function where we disable the phy (like it's done in D19389 for ehci).

I know that it wasn't done before (my bad ...) but since we are changing since might as well do it correctly :)

[val_packett.cool]

sys/dev/usb/controller/generic_xhci_fdt.c

33–50 ↗

(On Diff #56658)

We don't actually need xhcireg (I think I've seen an error related to that earlier, but removing it is fine now). We need xhci for the softc and all other USB stuff for xhci…

[val_packett.cool]

Added fdt detach corresponding to the current attach code (usb-phy)

[andrew]

sys/dev/usb/controller/generic_xhci_acpi.c

2–4 ↗

(On Diff #56915)

I doubt Semihalf and Stormshield own the copyright on this file.

[val_packett.cool]

sys/dev/usb/controller/generic_xhci_acpi.c

2–4 ↗

(On Diff #56915)

okay, I can put myself here I guess

(also added SPDX)

[manu]

Tinh Nguyen from Ampere tested and it doesn't seems to make usb working (xhci controller is discovered but nothing more), I've tried on my overdrive in FDT mode and it works.
In acpi mode this doesn't but it doesn't without this patch too, looks like the acpi table is missing info about interrupts, I'll do one more test on the macchiatobin and then commit this.