Split out the attachment from the generic-ehci driver
ClosedPublic
Actions

Authored by andrew on Feb 27 2019, 4:55 PM.

Details

Reviewers

Commits

rS355178: MFC r352940-r352941, r352943-r352944, r353062-r353063, r353125
rS353062: Split out the attachment from the generic-ehci driver

Summary

Create an attachment file for the existing ACPI attachment, and create a
new FDT attachment for the generic-ehci driver.

Test Plan

Boots on NanoPC-T4 (RokcChip RK3399) with GENERIC-UP. It seems to cause
a fault when SMP is enabled, however I'm unsure why.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Feb 27 2019, 4:55 PM

Herald added a subscriber: emaste. · View Herald TranscriptFeb 27 2019, 4:55 PM

Harbormaster completed remote builds in B22786: Diff 54486.Feb 27 2019, 4:55 PM

andrew added inline comments.Feb 27 2019, 4:58 PM

sys/dev/usb/controller/generic_ehci.c
187 ↗	(On Diff #54486)	I'm not sure this is the best name for it, but should be ok for testing.
sys/dev/usb/controller/generic_ehci_acpi.c
78 ↗	(On Diff #54486)	This should probably be in a header, although it will be the only thing in the header if it's `generic_ehci.h`.

This miss all the ext_resources stuff (phy, clocks) but that could be added later I guess.
Don't you need to DECLARE_CLASS and DEFINE_CLASS_0 ? (This stuff was always obscure to me ...)
Otherwise looks good for me.

sys/dev/usb/controller/generic_ehci.c
187 ↗	(On Diff #54486)	generic_ehci_driver ?

I've noticed a generic-ehci driver in sys/mips/mediatek/mtk_ehci.c already (and tried on my RK3399, it does attach). That should probably be replaced by this. Does anyone test mediatek MIPS these days? :)