Page MenuHomeFreeBSD

Improve error/debug messages in sdhci.c
ClosedPublic

Authored by bz on Mar 29 2019, 9:52 AM.
Tags
None
Referenced Files
F106144582: D19748.diff
Thu, Dec 26, 3:24 AM
Unknown Object (File)
Tue, Dec 3, 10:38 PM
Unknown Object (File)
Oct 4 2024, 1:50 PM
Unknown Object (File)
Oct 4 2024, 8:22 AM
Unknown Object (File)
Oct 4 2024, 1:24 AM
Unknown Object (File)
Oct 1 2024, 1:08 PM
Unknown Object (File)
Sep 30 2024, 6:04 AM
Unknown Object (File)
Sep 27 2024, 3:38 AM
Subscribers

Details

Summary

Improve error/debug messages in sdhci.c

When starting a command also print the opcode and flags.
More consitently print flags as hex.
Use slot_printf rather than printf in one case.

Sponsored by: The FreeBSD Foundation
MFC After: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me, it would be great if you could expand "Resp" to "Response" and use "result" instead of "err" for consistency while at it, though.

This revision is now accepted and ready to land.Mar 31 2019, 10:50 PM
This revision was automatically updated to reflect the committed changes.