Page MenuHomeFreeBSD
Differential D19748

Improve error/debug messages in sdhci.c
ClosedPublic
Actions

Authored by bz on Mar 29 2019, 9:52 AM.
Tags
None
Referenced Files
F81602983: D19748.id58147.diff
Thu, Apr 18, 7:36 PM
F81592794: D19748.diff
Thu, Apr 18, 3:50 PM
Unknown Object (File)
Thu, Mar 28, 8:59 PM
Unknown Object (File)
Wed, Mar 20, 5:58 PM
Unknown Object (File)
Jan 13 2024, 7:45 PM
Unknown Object (File)
Dec 20 2023, 4:32 AM
Unknown Object (File)
Dec 14 2023, 4:35 AM
Unknown Object (File)
Nov 8 2023, 5:13 PM
View All 28 Files
Subscribers
emaste

Details

Reviewers
marius
kibab
imp
loos
Commits
rS348493: Improve error/debug messages in sdhci.c
Summary

Improve error/debug messages in sdhci.c

When starting a command also print the opcode and flags.
More consitently print flags as hex.
Use slot_printf rather than printf in one case.

Sponsored by: The FreeBSD Foundation
MFC After: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 23377

Event Timeline

bz created this revision.Mar 29 2019, 9:52 AM
Harbormaster completed remote builds in B23377: Diff 55589.Mar 29 2019, 9:52 AM
marius accepted this revision.Mar 31 2019, 10:50 PM

Looks good to me, it would be great if you could expand "Resp" to "Response" and use "result" instead of "err" for consistency while at it, though.

This revision is now accepted and ready to land.Mar 31 2019, 10:50 PM
kibab accepted this revision.Apr 1 2019, 6:08 PM
imp accepted this revision.Apr 1 2019, 10:17 PM
Closed by commit rS348493: Improve error/debug messages in sdhci.c (authored by bz). · Explain WhyJun 1 2019, 2:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
sdhci/
8 lines

Diff 55589

View Options

sys/dev/sdhci/sdhci.c

Loading...