ports.7: Add an example of how to use flavors At the moment the manual page is not documenting how to build a flavored package. Let's start documenting flavors with an example of a typical use case. Requested by: cem, dim
Details
Details
- Reviewers
cem dim bcr - Group Reviewers
manpages - Commits
- rS345057: ports.7: Add an example of how to use flavors
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Small nit, the rest is fine. Thanks for adding the example, I think it is really useful to have.
share/man/man7/ports.7 | ||
---|---|---|
608 ↗ | (On Diff #54900) | s/examples/example/ |
share/man/man7/ports.7 | ||
---|---|---|
614 ↗ | (On Diff #54900) | Looking at how FLAVOR is passed to sub-makes in bsd.port.mk, I wonder if it should not be: env FLAVOR=py37 make build |
Comment Actions
- While here, fix a typo in example 2.
- Fix other typos.
- Use env(1) as suggested by @mat. As we can see in bsd.port.mk, it's better to pass FLAVOR via the environment:
1049 # Disallow forced FLAVOR as make argument since we cannot change it to the 1050 # proper default. 1051 .if empty(FLAVOR) && !empty(.MAKEOVERRIDES:MFLAVOR) 1052 .error FLAVOR may not be passed empty as a make argument. 1053 .endif
Comment Actions
Thanks for doing this, I really appreciate it!
share/man/man7/ports.7 | ||
---|---|---|
608–609 ↗ | (On Diff #54907) |
For example, "The following command …. of a port. (In this case... support.)"
(In this case, .Pa www/py-django is going to be built with Python 3.7 support.) |
share/man/man7/ports.7 | ||
---|---|---|
610 ↗ | (On Diff #54915) | www/py-django was deprecated and then undeprecated last week -- it's quite likely that it will disappear in the relatively near future. Maybe choose a different example port? |