Page MenuHomeFreeBSD

Use BASEDIR when checking for src component
ClosedPublic

Authored by aryeeteygerald_rogers.com on Jan 15 2019, 10:19 PM.

Details

Summary

src could potentially be installed under the based dir
and not under the root or vice versa.

This patch only supports the command line specified -b or
"BaseDir" in the configuration file if it appears *before*
the "Components" line.

PR: 224048

Test Plan

None

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 21975
Build 21211: arc lint + arc unit

Event Timeline

delphij requested changes to this revision.Jan 18 2019, 1:05 AM
delphij added inline comments.
usr.sbin/freebsd-update/freebsd-update.sh
231

Can we simply change /usr/src to ${BASEDIR}/usr/src here?

This revision now requires changes to proceed.Jan 18 2019, 1:05 AM
aryeeteygerald_rogers.com added inline comments.
usr.sbin/freebsd-update/freebsd-update.sh
231

I was worried about it not being defined earlier since that's possible, but it shouldn't matter

This revision is now accepted and ready to land.Jan 18 2019, 5:28 PM
This revision was automatically updated to reflect the committed changes.