pci_host_generic_acpi: use IORT data for MSI/MSI-X
ClosedPublic
Actions

Authored by jchandra on Nov 16 2018, 6:05 AM.

Details

Reviewers

andrew
markj

Group Reviewers

arm64

Commits

rS343860: pci_host_generic_acpi: use IORT data for MSI/MSI-X

Summary

Use the information from IORT parsing to translate the PCI RID to GIC ITS device ID. And similarly, use the information to find the PIC XREF identifier to be used for PCI devices.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 22361

Event Timeline

jchandra created this revision.Nov 16 2018, 6:05 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 16 2018, 6:05 AM

Harbormaster completed remote builds in B20833: Diff 50476.Nov 16 2018, 6:05 AM

pi added a subscriber: pi.Dec 21 2018, 8:06 PM

andrew added inline comments.Feb 4 2019, 5:26 PM

sys/dev/pci/pci_host_generic_acpi.c
360	This should check the return status.

I think this needs to be rebased too

Will rebase and submit a new rev addressing the comment.

sys/dev/pci/pci_host_generic_acpi.c
360	pcib_get_id is not likely to fail when type is PCI_ID_RID - so I didn't think it was needed. Anyway, I will fix it up.

jchandra updated this revision to Diff 53615.Feb 6 2019, 3:03 AM

Harbormaster completed remote builds in B22361: Diff 53615.Feb 6 2019, 3:03 AM

andrew accepted this revision.Feb 6 2019, 10:12 AM

This revision is now accepted and ready to land.Feb 6 2019, 10:12 AM

Closed by commit rS343860: pci_host_generic_acpi: use IORT data for MSI/MSI-X (authored by jchandra). · Explain WhyFeb 7 2019, 4:50 AM

This revision was automatically updated to reflect the committed changes.

jchandra mentioned this in rS352498: MFC r343853, r343856, r343860.Sep 18 2019, 11:09 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic_acpi.c

62 lines

Diff 53615

View Options

sys/dev/pci/pci_host_generic_acpi.c

pci_host_generic_acpi: use IORT data for MSI/MSI-XClosedPublicActions