Page MenuHomeFreeBSD

Add a regression test for D17914.
ClosedPublic

Authored by markj on Nov 9 2018, 6:01 PM.
Tags
None
Referenced Files
F153774735: D17926.id50237.diff
Thu, Apr 23, 3:18 PM
F153742375: D17926.diff
Thu, Apr 23, 9:01 AM
Unknown Object (File)
Sun, Apr 19, 10:20 PM
Unknown Object (File)
Tue, Apr 14, 6:48 PM
Unknown Object (File)
Tue, Apr 14, 4:50 PM
Unknown Object (File)
Mon, Apr 13, 7:55 AM
Unknown Object (File)
Sun, Apr 12, 7:10 AM
Unknown Object (File)
Wed, Apr 8, 8:22 AM
Subscribers

Details

Summary

I will address the XXX comment and add more test cases, but figured I'd
put this up now.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Don't hardcode loopback ifname or address.
  • Add a test for fragments with payload length 0.
  • Add tests for D17922
  • Use random IP IDs

Extend ip_reass__multiple_last_fragments

This test should really attempt to read the reassembled packet and verify its
contents. I'll try extending it along those lines, but I think that can be
handled in a separate commit.

LGTM after a somewhat cursory review.

This revision is now accepted and ready to land.Nov 10 2018, 8:21 PM
This revision was automatically updated to reflect the committed changes.