Page MenuHomeFreeBSD

Add a regression test for D17914.
ClosedPublic

Authored by markj on Nov 9 2018, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 9, 1:24 PM
Unknown Object (File)
Mon, Mar 9, 1:35 AM
Unknown Object (File)
Sun, Mar 8, 8:45 PM
Unknown Object (File)
Fri, Mar 6, 6:20 PM
Unknown Object (File)
Thu, Mar 5, 10:23 PM
Unknown Object (File)
Thu, Mar 5, 6:30 PM
Unknown Object (File)
Wed, Mar 4, 6:55 PM
Unknown Object (File)
Wed, Mar 4, 5:30 PM
Subscribers

Details

Summary

I will address the XXX comment and add more test cases, but figured I'd
put this up now.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Don't hardcode loopback ifname or address.
  • Add a test for fragments with payload length 0.
  • Add tests for D17922
  • Use random IP IDs

Extend ip_reass__multiple_last_fragments

This test should really attempt to read the reassembled packet and verify its
contents. I'll try extending it along those lines, but I think that can be
handled in a separate commit.

LGTM after a somewhat cursory review.

This revision is now accepted and ready to land.Nov 10 2018, 8:21 PM
This revision was automatically updated to reflect the committed changes.