Page MenuHomeFreeBSD
Differential D17633

pf: Make ':0' ignore link-local v6 addresses too
ClosedPublic
Actions

Authored by kp on Oct 21 2018, 12:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 6:42 PM
Unknown Object (File)
Sun, Nov 2, 11:09 AM
Unknown Object (File)
Sat, Nov 1, 5:35 AM
Unknown Object (File)
Sat, Nov 1, 2:43 AM
Unknown Object (File)
Sat, Nov 1, 1:38 AM
Unknown Object (File)
Tue, Oct 28, 5:31 AM
Unknown Object (File)
Mon, Oct 27, 3:12 AM
Unknown Object (File)
Thu, Oct 23, 10:55 PM
View All Files
Subscribers
bcr
farrokhi
• franco_opnsense.org
imp

Details

Reviewers
bcr
• franco_opnsense.org
0mp
Group Reviewers
network
manpages
Commits
rS339835: pf: Make ':0' ignore link-local v6 addresses too
Summary

When users mark an interface to not use aliases they likely also don't
want to use the link-local v6 address there.

PR: 201695
Submitted by: Russell Yount <Russell.Yount AT gmail.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Oct 21 2018, 12:37 AM
Herald added a subscriber: farrokhi. · View Herald TranscriptOct 21 2018, 12:37 AM
Harbormaster completed remote builds in B20316: Diff 49379.Oct 21 2018, 12:37 AM
kp added a reviewer: network.Oct 21 2018, 12:38 AM
kp set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: manpages. · View Herald TranscriptOct 21 2018, 12:38 AM
Herald added a subscriber: imp. · View Herald Transcript
bcr accepted this revision.Oct 21 2018, 12:44 AM
bcr added a subscriber: bcr.

OK from manpages. Can you bump the .Dd to the date of the commit for this content change? Thanks.

This revision is now accepted and ready to land.Oct 21 2018, 12:44 AM
• franco_opnsense.org added a subscriber: • franco_opnsense.org.Oct 21 2018, 4:10 PM
• franco_opnsense.org requested changes to this revision.Oct 21 2018, 4:16 PM

"if:0" and "(if:0)" have separate implementations. the one for "if:0" is missing, see ifa_lookup() in sbin/pfctl/pfctl_parser.c

This revision now requires changes to proceed.Oct 21 2018, 4:16 PM
kp updated this revision to Diff 49411.Oct 21 2018, 7:46 PM

Make :0 work without ()

Harbormaster completed remote builds in B20322: Diff 49411.Oct 21 2018, 7:46 PM
• franco_opnsense.org accepted this revision.Oct 24 2018, 5:34 AM
• franco_opnsense.org added inline comments.
sbin/pfctl/pfctl_parser.c
1369 ↗(On Diff #49411)

Implementations of kernel and userland seem to diverge for PFI_AFLAG_NETWORK due to other reason. Just a comment, no issue for this particular fix. Thanks!

This revision is now accepted and ready to land.Oct 24 2018, 5:34 AM
0mp accepted this revision.Oct 24 2018, 1:27 PM
Closed by commit rS339835: pf: Make ':0' ignore link-local v6 addresses too (authored by kp). · Explain WhyOct 28 2018, 5:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sbin/
pfctl/
3 lines
share/
man/
man5/
4 lines
sys/
netpfil/
pf/
3 lines

Diff 49716

View Options

head/sbin/pfctl/pfctl_parser.c

Loading...
View Options

head/share/man/man5/pf.conf.5

Loading...
View Options

head/sys/netpfil/pf/pf_if.c

Loading...