Page MenuHomeFreeBSD

Fix ips_localout counter for SCTP
ClosedPublic

Authored by tuexen on Oct 4 2018, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 6:18 AM
Unknown Object (File)
Fri, Oct 3, 2:31 PM
Unknown Object (File)
Fri, Oct 3, 1:17 PM
Unknown Object (File)
Fri, Oct 3, 7:41 AM
Unknown Object (File)
Thu, Sep 25, 6:02 PM
Unknown Object (File)
Tue, Sep 23, 2:38 AM
Unknown Object (File)
Sun, Sep 21, 12:18 PM
Unknown Object (File)
Sep 11 2025, 11:21 PM
Subscribers

Details

Summary

When sending SCTP packets, the SCTP stack provides an IPv4 or IPv6 header when calling ip_output() or ipv6_output(). Currently, the IPv4 stack does not count these packets using the ips_localout counter whereas the IPv6 stack does count them correctly in the ip6s_localout counter.

This patch ensures that packets sent via IPv4 with an IPv4 header provided by the caller of ip_output() are counted in the ips_localout counter.

Test Plan

Run an SCTP capable test program on the loopback interface and watch the counter using systat -ip.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looking at the how IP_FORWARDING flag is used, I think gif/gre/me interfaces should not use this flag. What you think?

This revision is now accepted and ready to land.Oct 4 2018, 2:00 PM
This revision was automatically updated to reflect the committed changes.
In D17406#371337, @ae wrote:

Looking at the how IP_FORWARDING flag is used, I think gif/gre/me interfaces should not use this flag. What you think?

Need to look into this. Will report in the next days.