Page MenuHomeFreeBSD

top(1): rework DESCRIPTION OF MEMORY section
ClosedPublic

Authored by 0mp on Oct 1 2018, 10:47 AM.
Tags
None
Referenced Files
F102034361: D17369.diff
Wed, Nov 6, 7:00 PM
F102034352: D17369.diff
Wed, Nov 6, 7:00 PM
Unknown Object (File)
Wed, Oct 16, 5:43 PM
Unknown Object (File)
Tue, Oct 15, 12:20 PM
Unknown Object (File)
Mon, Oct 14, 1:05 PM
Unknown Object (File)
Sat, Oct 12, 10:29 PM
Unknown Object (File)
Sat, Oct 12, 1:08 PM
Unknown Object (File)
Fri, Oct 11, 4:02 AM
Subscribers

Details

Reviewers
eadler
bcr
yuripv
mat
krion
Group Reviewers
manpages
Restricted Owners Package(Owns No Changed Paths)
Commits
rS339080: top(1): Rework DESCRIPTION OF MEMORY section.
Summary

Due to markup issues, the DESCRIPTION OF MEMORY section is rather unreadable; rework it a bit, using subsections for different lines of the top output, and move it closer to description.

While here, pet manlint ordering other sections as expected.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp added a subscriber: 0mp.

mdoc changes seem reasonable.

Is there a reason why we don't want to sort those stats alphabetically?

usr.bin/top/top.1
2 ↗(On Diff #48605)

Remember to dump the date.

421 ↗(On Diff #48605)

I think this might look better with -width "Uncompressed"

445 ↗(On Diff #48605)

Unnecessary newline?

This revision is now accepted and ready to land.Oct 1 2018, 11:02 AM
yuripv added inline comments.
usr.bin/top/top.1
421 ↗(On Diff #48605)

Yes, had the same thought, but then forgot about it.

yuripv marked an inline comment as done.
This revision now requires review to proceed.Oct 1 2018, 11:10 AM

The order currently follows what we have in the actual top output, and seems logically more correct than sorting alphabetically.

0mp added a reviewer: bcr.

Looks good to me.

This revision is now accepted and ready to land.Oct 1 2018, 11:12 AM
0mp edited reviewers, added: yuripv; removed: 0mp.
0mp added reviewers: mat, krion.
0mp added subscribers: krion, mat.

Cool. I can get it committed.

@krion, @mat, may I have your approval?

I think from now we agreed with mat@ you get blank approval from us for doc/ and src/ changes assuming these changes are approved from doc/ or src/ committers.

I think from now we agreed with mat@ you get blank approval from us for doc/ and src/ changes assuming these changes are approved from doc/ or src/ committers.

Thank you, @krion & @mat. That's a great honor. Thank you for your trust.

When it comes to the revision itself, I'll now submit it to re@.

Committed! Thanks, @yuripv_yuripv.net!

This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: Restricted Owners Package.Oct 2 2018, 8:14 AM