Convert UDP length to host byte order
ClosedPublic
Actions

Authored by thj on Sep 29 2018, 5:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 1, 5:15 AM

	Unknown Object (File)
	Tue, Dec 31, 5:12 AM

	Unknown Object (File)
	Mon, Dec 30, 5:44 AM

	Unknown Object (File)
	Sun, Dec 29, 5:33 AM

	Unknown Object (File)
	Sat, Dec 28, 6:23 AM

	Unknown Object (File)
	Fri, Dec 27, 5:34 PM

	Unknown Object (File)
	Thu, Dec 26, 12:24 AM

	Unknown Object (File)
	Dec 13 2024, 2:53 AM

View All 43 Files

Subscribers

imp

Details

Reviewers

jtl
tuexen
ae

Group Reviewers

transport

Commits

rS339195: Convert UDP length to host byte order

Summary

When getting the number of bytes to checksum make sure to convert the UDP
length to host byte order when the entire header is not in the first mbuf.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19876
Build 19402: arc lint + arc unit

Event Timeline

thj created this revision.Sep 29 2018, 5:04 PM

Harbormaster completed remote builds in B19876: Diff 48574.Sep 29 2018, 5:04 PM

thj added a reviewer: jtl.Sep 29 2018, 5:04 PM

thj added a reviewer: transport.Oct 1 2018, 11:41 AM

tuexen accepted this revision.Oct 1 2018, 11:47 AM

This revision is now accepted and ready to land.Oct 1 2018, 11:47 AM

ae accepted this revision.Oct 1 2018, 12:24 PM

Looks good. Please commit with "Approved: jtl (mentor)".

Don't forget that you'll also need to get RE approval before committing to head during the freeze.

Closed by commit rS339195: Convert UDP length to host byte order (authored by thj). · Explain WhyOct 5 2018, 12:51 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptOct 5 2018, 12:51 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_output.c

5 lines

Diff 48574

View Options

Convert UDP length to host byte orderClosedPublicActions