Page MenuHomeFreeBSD

Use arc4rand() instead of read_random()
ClosedPublic

Authored by tuexen on Aug 23 2018, 7:31 AM.

Details

Summary

jmg@ has suggested to use arc4rand() instead of read_random() as indicated by the man read_random.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tuexen created this revision.Aug 23 2018, 7:31 AM
jmg accepted this revision.Aug 23 2018, 3:22 PM
jmg added reviewers: gordon, delphij.

IMO, looks good to me.

Added our SO as well.

Add secteam instead of just me.

delphij accepted this revision.Aug 23 2018, 4:52 PM

LGTM.

It seems that the other read_random instances in network stack should do the same as well (probably beyond scope of this changeset though).

jtl accepted this revision.Aug 23 2018, 6:16 PM
This revision is now accepted and ready to land.Aug 23 2018, 6:16 PM
This revision was automatically updated to reflect the committed changes.