Don't run cc --version during cleandir/obj stages
ClosedPublic
Actions

Authored by arichardson on Aug 20 2018, 4:11 PM.

Details

Reviewers

jhb
bdrewery
brooks
emaste

Commits

rS339946: Don't run cc --version during cleandir/obj stages

Summary

This will no work when there is no cc in $PATH (which is the case before the
cross-tools stage once we no longer inherit $PATH in $WMAKE).
The variables set by bsd.compiler.mk/bsd.linker.mk are not needed in these
stages so this avoids a little bit of makefile parsing.

Test Plan

buildworld works with my patches to remove $PATH from $TMPPATH

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18976
Build 18614: arc lint + arc unit

Event Timeline

arichardson created this revision.Aug 20 2018, 4:11 PM

Herald added a subscriber: emaste. · View Herald TranscriptAug 20 2018, 4:11 PM

Harbormaster completed remote builds in B18976: Diff 46984.Aug 20 2018, 4:11 PM

arichardson mentioned this in D16815: Allow building world without inheriting $PATH.Aug 20 2018, 4:12 PM

Also add it to delete-old step

Harbormaster completed remote builds in B18979: Diff 46989.Aug 20 2018, 4:53 PM

arichardson added a child revision: D16815: Allow building world without inheriting $PATH.Aug 21 2018, 8:07 AM

jhb added inline comments.Aug 21 2018, 8:47 AM

share/mk/bsd.compiler.mk
32	I wonder if this blob should be inside the '.if !target' check so it is only done once per make invocation? Setting the variables multiple times probably doesn't matter, so it's probably more a style question for Bryan than anything else.
33	s/on/in/