Build the elftoolchain libraries as part of bootstrap-tools
ClosedPublic
Actions

Authored by arichardson on Nov 1 2018, 12:42 PM.

Details

Reviewers

emaste
jhb
brooks

Commits

rS340158: Build the elftoolchain libraries as part of bootstrap-tools

Summary

It is not necessary to build libelf and libdwarf this early. Furthermore,
when building on Linux/MacOS, m4 will only be built during the bootstrap
tools phase and not be available in $PATH before.

Test Plan

bootstrap still works

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Nov 1 2018, 12:42 PM

Harbormaster completed remote builds in B20569: Diff 49876.Nov 1 2018, 12:42 PM

arichardson added a parent revision: D16815: Allow building world without inheriting $PATH.Nov 1 2018, 12:43 PM

emaste added inline comments.Nov 1 2018, 1:04 PM

Makefile.inc1
1991–1996 ↗	(On Diff #49876)	This comment implies that libelf/libdwarf built in bootstrap-tools wouldn't be used by the rest of elftoolchain; if this is not the case we need to update this as well.

arichardson marked an inline comment as done.Nov 1 2018, 1:36 PM

arichardson added inline comments.

Makefile.inc1
1991–1996 ↗	(On Diff #49876)	Well they do use the host compiler and libraries. However, ${WORLDTMP}/legacy/lib is included in the `-L` flags so any libraries built during bootstrap-tools (such as libnetbsd, liby, etc) are found by the linker for the ones in /usr/lib.

emaste accepted this revision.Nov 1 2018, 7:39 PM

emaste added inline comments.

Makefile.inc1
1991–1996 ↗	(On Diff #49876)	Maybe "Bootstrap tools use the host's compiler and libraries, augmented by -legacy, in addition to the libraries built in bootstrap-tools.?