Don't create directories in ${WORLDTMP}/legacy with mtree
ClosedPublic
Actions

Authored by arichardson on Aug 17 2018, 3:54 PM.

Details

Reviewers

brooks
emaste
jhb
imp
bdrewery

Commits

rS338098: Don't create directories in ${WORLDTMP}/legacy with mtree

Summary

This has two advantages:

We no longer create lots of empty directories that are not needed
This is a requirement for building on non-FreeBSD hosts since mtree will

only exist after the bootstrap-tools phase there.

Test Plan

MIPS64 buildworld succeeded

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18903
Build 18557: arc lint + arc unit

Event Timeline

arichardson created this revision.Aug 17 2018, 3:54 PM

Harbormaster completed remote builds in B18901: Diff 46846.Aug 17 2018, 3:54 PM

Upload correct version of patch

Harbormaster completed remote builds in B18903: Diff 46849.Aug 17 2018, 4:06 PM

arichardson added inline comments.Aug 20 2018, 9:21 AM

tools/build/Makefile
72	I added this so that no matter which directory the bootstrap tool is installed in, we can always find it in ${WORLDTMP}/legacy/bin. This is useful when building without inheriting $PATH and symlinking the host tools in ${WORLDTMP}/legacy. I could also override BINDIR in Makefile.boot, but I think this is easier.

I suggest we just mkdir the extra bin dirs for now and change it to use symlinks as part of the patches that make use of explicit ${WORLDTMP}/legacy/bin.