Build a release vm
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18896 Build 18550: arc lint + arc unit
Event Timeline
Can you please break the change to share/mk/bsd.confs.mk out into a separate review, though it is required by the moving of the profile files, it is actually not a part of that change directly. I would also like to ask that you tag bdrewery in on the review of the .mk change. I do not see how file owner/group/mode are set in the new Makefile.
bin/csh/Makefile | ||
---|---|---|
11 | Hum, there is a conf group called ETC? Can I ask what is in it? This seems to be where maybe master.passwd belongs? As well as anything else that was moved to libc. | |
15 | Something makes me leary of these variable names, but I can not come up with what it is or what they would be called to make it better | |
157 | rm -f ${DESTDIR}/${ROOTNAME} | |
bin/sh/Makefile | ||
8 | Well I like these names better than what you did for csh, and why the difference between sh and csh in this respect? | |
67 | rm -f ${DESTDIR}/${CONFSNAME_dot.profile} | |
70 | There is a variable with .profile in it, please use it all places. | |
etc/Makefile | ||
181 | I do not seem to be able to find BINOWN BINGRP or mode 644 in the new specifications, how is that handled? |