Page MenuHomeFreeBSD
Differential D16746

Suggest to reboot after installworld in the example of development workflow.
ClosedPublic
Actions

Authored by 0mp on Aug 16 2018, 3:14 PM.
Tags
None
Referenced Files
F106170476: D16746.diff
Thu, Dec 26, 1:23 PM
Unknown Object (File)
Wed, Dec 11, 4:59 PM
Unknown Object (File)
Nov 13 2024, 12:16 PM
Unknown Object (File)
Nov 5 2024, 3:40 AM
Unknown Object (File)
Oct 14 2024, 6:18 PM
Unknown Object (File)
Sep 14 2024, 8:28 AM
Unknown Object (File)
Sep 5 2024, 5:54 AM
Unknown Object (File)
Aug 24 2024, 2:32 PM
View All 50 Files
Subscribers
eadler
imp
krion
mat

Details

Reviewers
bcr
trasz
krion
mat
Group Reviewers
manpages
Commits
rS338194: Suggest to reboot after installworld in the example of development workflow.
Summary

Inspired by the commit message introducing beinstall.sh: https://reviews.freebsd.org/rS302977.

Test Plan

igor, mandoc: OK

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18853
Build 18511: arc lint + arc unit

Event Timeline

0mp created this revision.Aug 16 2018, 3:14 PM
Herald added a reviewer: manpages. · View Herald TranscriptAug 16 2018, 3:14 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B18853: Diff 46779.Aug 16 2018, 3:14 PM
trasz accepted this revision.Aug 16 2018, 5:03 PM
This revision is now accepted and ready to land.Aug 16 2018, 5:03 PM
0mp requested review of this revision.Aug 22 2018, 10:26 AM
0mp added reviewers: krion, mat.
0mp added subscribers: krion, mat.

Thanks, @trasz.

@krion, @mat, may I ask you for an approval to commit these changes?

mat accepted this revision.Aug 22 2018, 11:33 AM
This revision is now accepted and ready to land.Aug 22 2018, 11:33 AM
mat requested changes to this revision.Aug 22 2018, 11:33 AM
This revision now requires changes to proceed.Aug 22 2018, 11:33 AM
mat accepted this revision.Aug 22 2018, 11:33 AM
This revision is now accepted and ready to land.Aug 22 2018, 11:33 AM
Closed by commit rS338194: Suggest to reboot after installworld in the example of development workflow. (authored by 0mp). · Explain WhyAug 22 2018, 1:25 PM
This revision was automatically updated to reflect the committed changes.
eadler added a subscriber: eadler.Aug 22 2018, 1:37 PM
eadler added inline comments.
head/share/man/man7/development.7
120 ↗(On Diff #47093)

We generally document shutdown(8) instead of reboot(8). Even the latter man page suggestions using `shutdown.

0mp marked an inline comment as done.Aug 22 2018, 2:02 PM
0mp added inline comments.
head/share/man/man7/development.7
120 ↗(On Diff #47093)

I've opened a new revision: https://reviews.freebsd.org/D16843

Revision Contents
Changeset List

PathSize
share/
man/
man7/
3 lines

Diff 46779

View Options

share/man/man7/development.7

Loading...