Don't use static on DPCPU data in arm64 modules
ClosedPublic
Actions

Authored by andrew on Jul 5 2018, 6:26 PM.

Details

Reviewers

bz
emaste
markj

Group Reviewers

arm64

Commits

rS336349: Don't use the static keyword with DPCPU defines in arm64 modules.

Summary

It is broken ad it doesn't emit a relocation for the in-kernel linker to
adjust. To work around this remove the static keyword from the
DPCPU_DEFINE_STATIC macro on arm64 when building modules.

PR: 225816

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17869
Build 17633: arc lint + arc unit

Event Timeline

andrew created this revision.Jul 5 2018, 6:26 PM

Harbormaster completed remote builds in B17869: Diff 44930.Jul 5 2018, 6:26 PM

Please also incorporate the one line subject summary into the description for the commit message.

sys/sys/pcpu.h
96	I think this should mention that this is an issue for file local static variables only and making them global the issue goes away. Also, I'd remove the "arm64" from the comment and say "certain architectures" to keep it general as this might effect more of them? I might also add a note that this is a "workaround" until better ways might be found?