Page MenuHomeFreeBSD
Differential D15575

iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN
ClosedPublic
Actions

Authored by erj on May 25 2018, 5:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 8, 3:09 AM
Unknown Object (File)
Sun, Feb 8, 12:38 AM
Unknown Object (File)
Sat, Feb 7, 6:15 PM
Unknown Object (File)
Sat, Feb 7, 1:44 AM
Unknown Object (File)
Tue, Feb 3, 11:50 PM
Unknown Object (File)
Sat, Jan 31, 1:15 AM
Unknown Object (File)
Fri, Jan 30, 8:57 PM
Unknown Object (File)
Tue, Jan 27, 11:00 AM
View All Files
Subscribers
ae
imp
Intel Networking

Details

Reviewers
gallatin
mmacy
shurd
sbruno
Commits
rS334231: iflib: Add new shared flag: IFLIB_ADMIN_ALWAYS_RUN
Summary

ixl(4)'s nvmupdate utility expects the nvmupdate process to run
while the interface is down; these nvm update commands use the
admin queue, so the admin queue needs to be able to generate
interrupts and be processed while the interface is down.

So add a flag that ixl(4) sets that lets the entire admin task
run even when the interface is marked down/IFF_DRV_RUNNING isn't set.

With this change, nvmupdate should function like it did pre-iflib.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

erj created this revision.May 25 2018, 5:45 PM
Herald added a subscriber: ae. · View Herald TranscriptMay 25 2018, 5:45 PM
Harbormaster completed remote builds in B16845: Diff 43003.May 25 2018, 5:45 PM
erj set the repository for this revision to rS FreeBSD src repository - subversion.May 25 2018, 5:46 PM
erj added a subscriber: Intel Networking.
Herald added a subscriber: imp. · View Herald TranscriptMay 25 2018, 5:46 PM
sbruno accepted this revision.May 25 2018, 5:58 PM
This revision is now accepted and ready to land.May 25 2018, 5:58 PM
gallatin added inline comments.May 25 2018, 6:31 PM
sys/net/iflib.c
3811 ↗(On Diff #43003)

Style: The && should go at the end of the previous line

erj updated this revision to Diff 43015.May 25 2018, 7:36 PM
  • Make style fix.
This revision now requires review to proceed.May 25 2018, 7:36 PM
erj marked an inline comment as done.May 25 2018, 7:37 PM
Harbormaster completed remote builds in B16851: Diff 43015.May 25 2018, 7:37 PM
gallatin accepted this revision.May 25 2018, 8:16 PM
This revision is now accepted and ready to land.May 25 2018, 8:16 PM
Closed by commit rS334231: iflib: Add new shared flag: IFLIB_ADMIN_ALWAYS_RUN (authored by erj). · Explain WhyMay 26 2018, 12:46 AM
This revision was automatically updated to reflect the committed changes.
erj mentioned this in D15577: Update ixl(4) to use iflib..May 26 2018, 1:08 AM

Revision Contents
Changeset List

PathSize
head/
sys/
net/
5 lines
3 lines

Diff 43027

View Options

head/sys/net/iflib.h

Loading...
View Options

head/sys/net/iflib.c

Loading...