Page MenuHomeFreeBSD

Migrate top(1) to usr.bin
ClosedPublic

Authored by eadler on May 11 2018, 4:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 28 2024, 4:55 PM
Unknown Object (File)
Oct 24 2024, 7:58 PM
Unknown Object (File)
Oct 24 2024, 7:58 PM
Unknown Object (File)
Oct 24 2024, 7:56 PM
Unknown Object (File)
Oct 24 2024, 7:56 PM
Unknown Object (File)
Oct 24 2024, 7:36 PM
Unknown Object (File)
Oct 6 2024, 1:49 PM
Unknown Object (File)
Oct 3 2024, 10:07 PM
Subscribers

Details

Summary

We've been maintaining top(1) for a long time, and the upstream
hasn't existed/been used in similarly as long. Make it clear that we own
top(1)

Test Plan

I tested make/install world and am in the process of testing universe. I
have little experience with our build system, so I likely messed up
somewhere.

--------------------------------------------------------------
>>> make universe started on Fri May 11 03:42:14 UTC 2018
--------------------------------------------------------------
>> riscv skipped - install riscv64-xtoolchain-gcc port or package to build
>> amd64 started on Fri May 11 03:42:14 UTC 2018
>> amd64.amd64 buildworld started on Fri May 11 03:42:14 UTC 2018
>> amd64.amd64 buildworld completed on Fri May 11 04:08:05 UTC 2018
>> amd64 completed on Fri May 11 04:08:05 UTC 2018
>> arm started on Fri May 11 04:08:05 UTC 2018
>> arm.arm buildworld started on Fri May 11 04:08:05 UTC 2018
>> arm.arm buildworld completed on Fri May 11 04:36:25 UTC 2018
>> arm.armeb buildworld started on Fri May 11 04:36:25 UTC 2018
>> arm.armeb buildworld completed on Fri May 11 05:00:10 UTC 2018
>> arm.armv6 buildworld started on Fri May 11 05:00:10 UTC 2018
>> arm.armv6 buildworld completed on Fri May 11 05:26:59 UTC 2018
>> arm.armv7 buildworld started on Fri May 11 05:26:59 UTC 2018
>> arm.armv7 buildworld completed on Fri May 11 05:49:24 UTC 2018
>> arm completed on Fri May 11 05:49:24 UTC 2018
>> arm64 started on Fri May 11 05:49:24 UTC 2018
>> arm64.aarch64 buildworld started on Fri May 11 05:49:24 UTC 2018
>> arm64.aarch64 buildworld completed on Fri May 11 06:24:04 UTC 2018
>> arm64 completed on Fri May 11 06:24:04 UTC 2018
>> i386 started on Fri May 11 06:24:04 UTC 2018
>> i386.i386 buildworld started on Fri May 11 06:24:04 UTC 2018
>> i386.i386 buildworld completed on Fri May 11 06:47:59 UTC 2018
>> i386 completed on Fri May 11 06:47:59 UTC 2018
>> mips started on Fri May 11 06:47:59 UTC 2018
>> mips.mipsel buildworld started on Fri May 11 06:47:59 UTC 2018
mips.mipsel buildworld failed, check _.mips.mipsel.buildworld for details
>> mips.mipsel buildworld completed on Fri May 11 06:52:57 UTC 2018
>> mips.mips buildworld started on Fri May 11 06:52:57 UTC 2018
mips.mips buildworld failed, check _.mips.mips.buildworld for details
>> mips.mips buildworld completed on Fri May 11 06:57:57 UTC 2018
>> mips.mips64el buildworld started on Fri May 11 06:57:57 UTC 2018
mips.mips64el buildworld failed, check _.mips.mips64el.buildworld for details
>> mips.mips64el buildworld completed on Fri May 11 07:02:25 UTC 2018

failures look unrelated

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

looks like you've removed a lot of keywords...

In D15387#324402, @imp wrote:

looks like you've removed a lot of keywords...

I think that's an artifact of how phab is displaying the diff:

∴svn proplist usr.bin/top/commands.h   
Properties on 'usr.bin/top/commands.h':
  svn:eol-style
  svn:keywords
  svn:mime-type
[7958 04:01:52.740 eax@fasteagle /srv/src/freebsd/3.head]∴svn propget svn:eol-style usr.bin/top/commands.h         
native

Do you need to update ObsoleteFiles in order to remove the old version?

Do you need to update ObsoleteFiles in order to remove the old version?

This is just moving the source files. It installs to the same place.

Do you need to update ObsoleteFiles in order to remove the old version?

This is just moving the source files. It installs to the same place.

ok then. Godspeed.

This revision is now accepted and ready to land.May 19 2018, 9:32 PM
This revision was automatically updated to reflect the committed changes.