Page MenuHomeFreeBSD
Differential D15300

iflib: print message when iflib_tx_structures_setup fails
ClosedPublic
Actions

Authored by jacob.e.keller_intel.com on May 4 2018, 6:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 1:53 PM
Unknown Object (File)
Thu, Jan 2, 4:50 PM
Unknown Object (File)
Tue, Dec 17, 4:12 PM
Unknown Object (File)
Dec 5 2024, 12:12 AM
Unknown Object (File)
Nov 22 2024, 5:51 PM
Unknown Object (File)
Oct 25 2024, 8:22 AM
Unknown Object (File)
Oct 1 2024, 10:40 AM
Unknown Object (File)
Sep 28 2024, 12:50 PM
View All 46 Files
Subscribers
ae
imp

Details

Reviewers
kmacy
gallatin
scottl
shurd
sbruno
cem
Commits
rS333373: iflib: print message when iflib_tx_structures_setup fails
Summary

Print a message when iflib_tx_structures_setup fails, like we do for
iflib_rx_structures_setup.

Now that we always print a message from within
iflib_qset_structures_setup when it fails, stop printing one in
iflib_device_register() at the call site.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jacob.e.keller_intel.com created this revision.May 4 2018, 6:53 PM
Herald added a subscriber: ae. · View Herald TranscriptMay 4 2018, 6:53 PM
Harbormaster completed remote builds in B16433: Diff 42151.May 4 2018, 6:53 PM
cem accepted this revision.May 4 2018, 6:57 PM
This revision is now accepted and ready to land.May 4 2018, 6:57 PM
gallatin accepted this revision.May 4 2018, 7:58 PM

As mentioned on the other review, maybe remove the print in the caller, since it is now redundant..

jacob.e.keller_intel.com added a comment.May 4 2018, 8:40 PM

As mentioned on the other review, maybe remove the print in the caller, since it is now redundant..

Makes sense. Should I update this review? or make it a separate one?

gallatin added a comment.May 4 2018, 10:14 PM

I'd just update this review.

jacob.e.keller_intel.com updated this revision to Diff 42160.May 4 2018, 11:32 PM

Remove the redundant message in iflib_device_register

This revision now requires review to proceed.May 4 2018, 11:32 PM
Harbormaster completed remote builds in B16440: Diff 42160.May 4 2018, 11:32 PM
jacob.e.keller_intel.com edited the summary of this revision. (Show Details)May 4 2018, 11:33 PM
gallatin accepted this revision.May 4 2018, 11:33 PM
This revision is now accepted and ready to land.May 4 2018, 11:33 PM
Closed by commit rS333373: iflib: print message when iflib_tx_structures_setup fails (authored by shurd). · Explain WhyMay 8 2018, 5:15 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 8 2018, 5:15 PM

Revision Contents
Changeset List

PathSize
head/
sys/
net/
8 lines

Diff 42277

View Options

head/sys/net/iflib.c

Loading...