linuxulator: do not include legacy syscalls on arm64
ClosedPublic
Actions

Authored by emaste on Apr 30 2018, 12:51 PM.

Details

Reviewers

dchagin
chuck
andrew

Commits

rS335201: linuxulator: do not include legacy syscalls on arm64

Summary

Existing linuxulator platforms (i386, amd64) support legacy syscalls, such as non-*at ones like open, but arm64 and other new platforms do not.

Wrap these in #ifdef LINUX_LEGACY_SYSCALLS, #defined in the MD linux.h files. We may need finer grained control in the future but this is sufficient for now.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Apr 30 2018, 12:51 PM

emaste added reviewers: chuck, andrew.Jun 15 2018, 1:02 PM

emaste added inline comments.

sys/compat/linux/linux_stats.c
84–99 ↗	(On Diff #41997)	will add `#ifdef LINUX_LEGACY_SYSCALLS` around these static fns too

How will this work if we decide to add linux32 on arm64? I expect we will need to implement the legacy syscalls there.

In D15237#334538, @andrew wrote:

How will this work if we decide to add linux32 on arm64? I expect we will need to implement the legacy syscalls there.

Looks like the syscall files are compiled separately into linux.ko and linux64.ko so we can just #define LINUX_LEGACY_SYSCALLS for 32-bit arm.

andrew accepted this revision.Jun 15 2018, 2:03 PM

This revision is now accepted and ready to land.Jun 15 2018, 2:03 PM

Closed by commit rS335201: linuxulator: do not include legacy syscalls on arm64 (authored by emaste). · Explain WhyJun 15 2018, 2:42 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2018, 2:42 PM