Page MenuHomeFreeBSD

Remove support for ixgb(4)
ClosedPublic

Authored by kbowling on Apr 30 2018, 8:22 AM.

Details

Summary

This driver was for an early and uncommon legacy PCI 10GbE for a single ASIC, Intel 82597EX. Intel quickly shifted to the long lived ixgbe family.

Relnotes: Yes

Justification: removing this will aid in network device API cleanup in FreeBSD 12 and later. This driver is not maintained, low in performance, high in power use, and the HW is too scarce to obtain for test and continued support.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

kbowling created this revision.Apr 30 2018, 8:22 AM
sbruno accepted this revision.Apr 30 2018, 2:12 PM

Agreed on all points. This driver can continue to be used on FreeBSD 11, but has no business in FreeBSD 12.

This revision is now accepted and ready to land.Apr 30 2018, 2:12 PM
brooks accepted this revision.Apr 30 2018, 9:40 PM

I'm fine with this in concept. There should first be a commit adding deprecation notices to the attach routine and manpage.

sbruno requested changes to this revision.Apr 30 2018, 9:59 PM

chatted with @brooks in IRC.

What we "want" for our users is a notification of sorts. So, I'll create an initial commit to -current that adds deprecation notices. We can then MFC *that* notice to stable/11, then commit this review to delete the driver. Sound good?

This revision now requires changes to proceed.Apr 30 2018, 9:59 PM
emaste added a subscriber: emaste.Apr 30 2018, 10:01 PM

rS332966 is a recent example of a deprecation notice

imp accepted this revision.Apr 30 2018, 10:12 PM

This is fine, but I'd let bruno's deprecation notice get in first so he can MFC it via normal means....

ObsoleteFiles.inc
41

likely need to bump the date...

UPDATING
54

ditto

sbruno accepted this revision.May 2 2018, 3:58 PM

I've added the correct dates and will commit this.

This revision is now accepted and ready to land.May 2 2018, 3:58 PM
sbruno closed this revision.May 2 2018, 4:00 PM