Differential D15234

Remove support for ixgb(4)
ClosedPublic
Actions

Authored by kbowling on Apr 30 2018, 8:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 9 2024, 11:09 AM

	Unknown Object (File)
	Oct 11 2024, 2:43 PM

	Unknown Object (File)
	Sep 27 2024, 8:14 AM

	Unknown Object (File)
	Sep 15 2024, 9:14 PM

	Unknown Object (File)
	Sep 9 2024, 3:22 AM

	Unknown Object (File)
	Sep 8 2024, 7:21 AM

	Unknown Object (File)
	Sep 7 2024, 6:14 AM

	Unknown Object (File)
	Sep 6 2024, 10:58 AM

View All 52 Files

Subscribers

Details

Reviewers

brooks
sbruno
jeffrey.e.pieper_intel.com
imp

Group Reviewers

Intel Networking
manpages

Commits

rS333173: Retire ixgb(4)

Summary

This driver was for an early and uncommon legacy PCI 10GbE for a single ASIC, Intel 82597EX. Intel quickly shifted to the long lived ixgbe family.

Relnotes: Yes

Justification: removing this will aid in network device API cleanup in FreeBSD 12 and later. This driver is not maintained, low in performance, high in power use, and the HW is too scarce to obtain for test and continued support.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Apr 30 2018, 8:22 AM

Herald added a reviewer: manpages. · View Herald TranscriptApr 30 2018, 8:22 AM

Herald added a subscriber: imp. · View Herald Transcript

Agreed on all points. This driver can continue to be used on FreeBSD 11, but has no business in FreeBSD 12.

This revision is now accepted and ready to land.Apr 30 2018, 2:12 PM

jeffrey.e.pieper_intel.com accepted this revision.Apr 30 2018, 4:49 PM

I'm fine with this in concept. There should first be a commit adding deprecation notices to the attach routine and manpage.

chatted with @brooks in IRC.

What we "want" for our users is a notification of sorts. So, I'll create an initial commit to -current that adds deprecation notices. We can then MFC *that* notice to stable/11, then commit this review to delete the driver. Sound good?

This revision now requires changes to proceed.Apr 30 2018, 9:59 PM

rS332966 is a recent example of a deprecation notice

sbruno added a parent revision: D15244: ixgb(4): Add Deprecation Notice.Apr 30 2018, 10:08 PM

This is fine, but I'd let bruno's deprecation notice get in first so he can MFC it via normal means....

ObsoleteFiles.inc
41	likely need to bump the date...
UPDATING
54	ditto

I've added the correct dates and will commit this.

This revision is now accepted and ready to land.May 2 2018, 3:58 PM

sbruno closed this revision.May 2 2018, 4:00 PM

Revision Contents
Changeset List

Path

Size

ObsoleteFiles.inc

2 lines

5 lines

share/

man/

man4/

2 lines

125 lines

1 line

1 line

sys/

conf/

1 line

3 lines

dev/

ixgb/

33 lines

237 lines

384 lines

2533 lines

if_ixgb_osdep.h

121 lines

118 lines

782 lines

858 lines

1223 lines

58 lines

i386/

conf/

1 line

modules/

2 lines

ixgb/

9 lines

netpfil/

pf/

3 lines

sparc64/

conf/

1 line

tools/

kerneldoc/

subsys/

Doxyfile-dev_ixgb

21 lines

tools/

tinybsd/

conf/

bridge/

1 line

default/

1 line

firewall/

1 line

vpn/

1 line

wireless/

1 line

wrap/

1 line

usr.sbin/

bsdconfig/

share/

1 line

Diff 41990

ObsoleteFiles.inc

Loading...

UPDATING

Loading...

share/man/man4/Makefile

Loading...

share/man/man4/ixgb.4

Loading...

share/man/man4/polling.4

Loading...

share/man/man4/vlan.4

Loading...

sys/conf/NOTES

Loading...

sys/conf/files

Loading...

sys/dev/ixgb/LICENSE

Loading...

sys/dev/ixgb/README

Loading...

sys/dev/ixgb/if_ixgb.h

Loading...

sys/dev/ixgb/if_ixgb.c

Loading...

sys/dev/ixgb/if_ixgb_osdep.h

Loading...

sys/dev/ixgb/ixgb_ee.h

Loading...

sys/dev/ixgb/ixgb_ee.c

Loading...

sys/dev/ixgb/ixgb_hw.h

Loading...

sys/dev/ixgb/ixgb_hw.c

Loading...

sys/dev/ixgb/ixgb_ids.h

Loading...

sys/i386/conf/GENERIC

Loading...

sys/modules/Makefile

Loading...

sys/modules/ixgb/Makefile

Loading...

sys/netpfil/pf/pf.c

Loading...

sys/sparc64/conf/GENERIC

Loading...

tools/kerneldoc/subsys/Doxyfile-dev_ixgb

Loading...

tools/tools/tinybsd/conf/bridge/TINYBSD

Loading...

tools/tools/tinybsd/conf/default/TINYBSD

Loading...

tools/tools/tinybsd/conf/firewall/TINYBSD

Loading...

tools/tools/tinybsd/conf/vpn/TINYBSD

Loading...

tools/tools/tinybsd/conf/wireless/TINYBSD

Loading...

tools/tools/tinybsd/conf/wrap/TINYBSD

Loading...

usr.sbin/bsdconfig/share/device.subr

Loading...