Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 30, 11:38 PM
Unknown Object (File)
Wed, Dec 24, 5:17 PM
Unknown Object (File)
Dec 12 2025, 4:21 AM
Unknown Object (File)
Dec 10 2025, 12:16 PM
Unknown Object (File)
Dec 9 2025, 6:26 PM
Unknown Object (File)
Nov 25 2025, 1:56 PM
Unknown Object (File)
Nov 21 2025, 12:50 AM
Unknown Object (File)
Nov 21 2025, 12:49 AM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable