Differential D14937

Fix LRO window comparison
ClosedPublic
Actions

Authored by jtl on Apr 2 2018, 6:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 2, 4:52 PM

	Unknown Object (File)
	Wed, May 20, 2:55 PM

	Unknown Object (File)
	Wed, May 20, 5:44 AM

	Unknown Object (File)
	Tue, May 19, 10:51 PM

	Unknown Object (File)
	Sun, May 17, 12:13 AM

	Unknown Object (File)
	May 6 2026, 3:15 PM

	Unknown Object (File)
	May 4 2026, 2:43 AM

	Unknown Object (File)
	Apr 30 2026, 12:35 AM

Subscribers

Details

Reviewers

jason_eggnet.com
gallatin
rrs
rstone
kbowling

Group Reviewers

Commits

rS331926: r330675 introduced an extra window check in the LRO code to ensure it

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl created this revision.Apr 2 2018, 6:46 PM

Herald added a reviewer: transport. · View Herald TranscriptApr 2 2018, 6:46 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B15944: Diff 40998.Apr 2 2018, 6:46 PM

kbowling accepted this revision.Apr 3 2018, 6:15 AM

This revision is now accepted and ready to land.Apr 3 2018, 6:15 AM

gallatin accepted this revision.Apr 3 2018, 12:44 PM

Closed by commit rS331926: r330675 introduced an extra window check in the LRO code to ensure it (authored by jtl). · Explain WhyApr 3 2018, 1:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

8 lines

Diff 41018

head/sys/netinet/tcp_seq.h

Loading...