Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
F164842061: D14937.id40998.diff
Tue, Aug 4, 7:10 AM
F164816698: D14937.id41018.diff
Tue, Aug 4, 4:45 AM
F164781895: D14937.id.diff
Tue, Aug 4, 12:22 AM
Unknown Object (File)
Mon, Aug 3, 8:40 AM
Unknown Object (File)
Sat, Aug 1, 2:41 AM
Unknown Object (File)
Wed, Jul 29, 11:17 AM
Unknown Object (File)
Sat, Jul 25, 10:39 PM
Unknown Object (File)
Sat, Jul 25, 1:10 PM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable