Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
F139230790: D14937.id41018.diff
Tue, Dec 9, 6:26 PM
Unknown Object (File)
Tue, Nov 25, 1:56 PM
Unknown Object (File)
Fri, Nov 21, 12:50 AM
Unknown Object (File)
Fri, Nov 21, 12:49 AM
Unknown Object (File)
Fri, Nov 21, 12:48 AM
Unknown Object (File)
Fri, Nov 21, 12:46 AM
Unknown Object (File)
Tue, Nov 18, 1:39 PM
Unknown Object (File)
Sun, Nov 16, 4:45 PM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable