Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 6:14 AM
Unknown Object (File)
Oct 20 2024, 10:40 AM
Unknown Object (File)
Oct 5 2024, 12:49 PM
Unknown Object (File)
Oct 5 2024, 12:59 AM
Unknown Object (File)
Oct 2 2024, 5:08 PM
Unknown Object (File)
Oct 2 2024, 9:20 AM
Unknown Object (File)
Oct 1 2024, 6:36 PM
Unknown Object (File)
Oct 1 2024, 6:50 AM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable