Page MenuHomeFreeBSD

arm64 linuxulator syscalls.master style review
ClosedPublic

Authored by emaste on Mar 26 2018, 8:40 PM.

Details

Summary

This is a syscalls.master for arm64 linuxulator.

Existing Linuxulator (and other) syscalls.master files are a bit of a mess, with inconsistent wrapping at either 80, 81, about 100, or 108 characters. I have a few different style proposals here for discussion before applying to the whole file.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Mar 26 2018, 8:40 PM

I have a strong preference for something like #1 where each argument goes on it's own line. That would greatly the ease of changes like D14285. It will also simplify review of type improvements such as adding const to path strings.

emaste updated this revision to Diff 57089.May 6 2019, 1:57 PM

Reformat arm64 linux syscalls.master per current style

Equivalent to rS339958 for sys/kern/syscalls.master.

Sponsored by: The FreeBSD Foundation

dchagin accepted this revision.May 6 2019, 2:10 PM

I like it

This revision is now accepted and ready to land.May 6 2019, 2:10 PM
emaste added inline comments.May 6 2019, 2:33 PM
sys/arm64/linux/syscalls.master
1558–1559 ↗(On Diff #57089)

One overzealous replacement here fixed in local tree - should be l_int pkey

This revision was automatically updated to reflect the committed changes.