Page MenuHomeFreeBSD

stand/fdt: Fix loading of multiple fdt_overlays
ClosedPublic

Authored by kevans on Dec 28 2017, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 7:58 PM
Unknown Object (File)
Fri, Mar 22, 7:58 PM
Unknown Object (File)
Fri, Mar 22, 7:58 PM
Unknown Object (File)
Sat, Mar 9, 11:02 AM
Unknown Object (File)
Jan 9 2024, 1:11 AM
Unknown Object (File)
Jan 3 2024, 10:27 PM
Unknown Object (File)
Jan 3 2024, 10:27 PM
Unknown Object (File)
Jan 3 2024, 10:27 PM
Subscribers

Details

Summary

fdt_load_dtb_overlays was written to unload previous overlay when a new valid one is come across. fdt_apply_overlays further down is written to iterate over all .dtbo's currently loaded and apply them one-by-one. Correct fdt_load_dtb_overlays to stop dropping valid overlays that were previously loaded and match expectations.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 13881

Event Timeline

my naive reading says this is right.

This revision is now accepted and ready to land.Dec 28 2017, 1:50 AM

Did you test multiple overlays targeting the same node ?
Last time I talk to gonzo@ about he came to the conclusion that we need to update libfdt in our tree and use their overlay implementation.

In D13659#285514, @manu wrote:

Did you test multiple overlays targeting the same node ?
Last time I talk to gonzo@ about he came to the conclusion that we need to update libfdt in our tree and use their overlay implementation.

These are two independent issues: inability to modify same node and discarding previously loaded dtbo's. I think the latter was just a case of poorly applied copy-patse.

These are two independent issues: inability to modify same node and discarding previously loaded dtbo's. I think the latter was just a case of poorly applied copy-patse.

Sorry, I forgot to mention here- after D13663 and D13664, I've had no problems modifying the same node in different .dtbo

This revision was automatically updated to reflect the committed changes.