Page MenuHomeFreeBSD

stand/fdt: Avoid bailout when dtbo has no fixups
ClosedPublic

Authored by kevans on Dec 28 2017, 2:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 10, 2:33 PM
Unknown Object (File)
Wed, Dec 3, 10:13 PM
Unknown Object (File)
Sun, Nov 30, 12:08 AM
Unknown Object (File)
Sat, Nov 29, 6:58 AM
Unknown Object (File)
Fri, Nov 28, 9:34 PM
Unknown Object (File)
Thu, Nov 27, 3:01 PM
Unknown Object (File)
Thu, Nov 27, 9:50 AM
Unknown Object (File)
Thu, Nov 27, 2:54 AM
Subscribers

Details

Summary

In the case of a simple dtbo where fragment uses target-path and the overlay contains no references, /__fixups__ will not be included by either our dtc or dtc from ports, but the file still has valid fragments to be applied. My single test fragment:

target-path = "/soc/ethernet";
__overlay__ {
    phy-mode = "rgmii-txid";
};

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans retitled this revision from stand/fdt: Fix bailout when dtbo has no fixups to stand/fdt: Avoid bailout when dtbo has no fixups.Dec 28 2017, 2:42 PM

Further testing showed that one of the dt compilers I tried emitted empty /__symbols__ while the other just omitted /__symbols__ since it was empty. I don't know if omitting it is OK according to whatever spec we may follow, but allowing it doesn't seem harmful.

This revision is now accepted and ready to land.Dec 28 2017, 4:56 PM
This revision was automatically updated to reflect the committed changes.