stand/fdt: Avoid bailout when dtbo has no fixups
ClosedPublic

Authored by kevans on Dec 28 2017, 2:42 PM.

Details

Summary

In the case of a simple dtbo where fragment uses target-path and the overlay contains no references, /__fixups__ will not be included by either our dtc or dtc from ports, but the file still has valid fragments to be applied. My single test fragment:

target-path = "/soc/ethernet";
__overlay__ {
    phy-mode = "rgmii-txid";
};

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kevans created this revision.Dec 28 2017, 2:42 PM
kevans retitled this revision from stand/fdt: Fix bailout when dtbo has no fixups to stand/fdt: Avoid bailout when dtbo has no fixups.Dec 28 2017, 2:42 PM
kevans updated this revision to Diff 37138.Dec 28 2017, 3:52 PM

Further testing showed that one of the dt compilers I tried emitted empty /__symbols__ while the other just omitted /__symbols__ since it was empty. I don't know if omitting it is OK according to whatever spec we may follow, but allowing it doesn't seem harmful.

imp accepted this revision.Dec 28 2017, 4:56 PM
This revision is now accepted and ready to land.Dec 28 2017, 4:56 PM
gonzo accepted this revision.Dec 28 2017, 9:08 PM
This revision was automatically updated to reflect the committed changes.