Page MenuHomeFreeBSD

stand/fdt: Fix loading of multiple fdt_overlays
ClosedPublic

Authored by kevans on Dec 28 2017, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 11, 6:56 PM
Unknown Object (File)
Tue, Mar 10, 11:05 PM
Unknown Object (File)
Fri, Mar 6, 6:07 PM
Unknown Object (File)
Wed, Mar 4, 9:42 AM
Unknown Object (File)
Tue, Mar 3, 10:01 PM
Unknown Object (File)
Feb 18 2026, 4:25 AM
Unknown Object (File)
Feb 17 2026, 11:02 AM
Unknown Object (File)
Feb 16 2026, 9:09 AM
Subscribers

Details

Summary

fdt_load_dtb_overlays was written to unload previous overlay when a new valid one is come across. fdt_apply_overlays further down is written to iterate over all .dtbo's currently loaded and apply them one-by-one. Correct fdt_load_dtb_overlays to stop dropping valid overlays that were previously loaded and match expectations.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

my naive reading says this is right.

This revision is now accepted and ready to land.Dec 28 2017, 1:50 AM

Did you test multiple overlays targeting the same node ?
Last time I talk to gonzo@ about he came to the conclusion that we need to update libfdt in our tree and use their overlay implementation.

In D13659#285514, @manu wrote:

Did you test multiple overlays targeting the same node ?
Last time I talk to gonzo@ about he came to the conclusion that we need to update libfdt in our tree and use their overlay implementation.

These are two independent issues: inability to modify same node and discarding previously loaded dtbo's. I think the latter was just a case of poorly applied copy-patse.

These are two independent issues: inability to modify same node and discarding previously loaded dtbo's. I think the latter was just a case of poorly applied copy-patse.

Sorry, I forgot to mention here- after D13663 and D13664, I've had no problems modifying the same node in different .dtbo

This revision was automatically updated to reflect the committed changes.