Page MenuHomeFreeBSD

stand/fdt: Fix loading of multiple fdt_overlays
ClosedPublic

Authored by kevans on Dec 28 2017, 1:39 AM.

Details

Summary

fdt_load_dtb_overlays was written to unload previous overlay when a new valid one is come across. fdt_apply_overlays further down is written to iterate over all .dtbo's currently loaded and apply them one-by-one. Correct fdt_load_dtb_overlays to stop dropping valid overlays that were previously loaded and match expectations.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kevans created this revision.Dec 28 2017, 1:39 AM
imp accepted this revision.Dec 28 2017, 1:50 AM

my naive reading says this is right.

This revision is now accepted and ready to land.Dec 28 2017, 1:50 AM
manu added a comment.Dec 28 2017, 7:33 AM

Did you test multiple overlays targeting the same node ?
Last time I talk to gonzo@ about he came to the conclusion that we need to update libfdt in our tree and use their overlay implementation.

gonzo added a comment.Dec 28 2017, 9:00 PM
In D13659#285514, @manu wrote:

Did you test multiple overlays targeting the same node ?
Last time I talk to gonzo@ about he came to the conclusion that we need to update libfdt in our tree and use their overlay implementation.

These are two independent issues: inability to modify same node and discarding previously loaded dtbo's. I think the latter was just a case of poorly applied copy-patse.

gonzo accepted this revision.Dec 28 2017, 9:00 PM

These are two independent issues: inability to modify same node and discarding previously loaded dtbo's. I think the latter was just a case of poorly applied copy-patse.

Sorry, I forgot to mention here- after D13663 and D13664, I've had no problems modifying the same node in different .dtbo

This revision was automatically updated to reflect the committed changes.