Page MenuHomeFreeBSD

stand/fdt: Consistently apply fdt_overlays
ClosedPublic

Authored by kevans on Dec 28 2017, 2:46 PM.

Details

Summary

Overlays were previously not applied when U-Boot provides FDT or EFI provides FDT, only when we load FDT from /boot/dtb given name from U-Boot. Make all three paths lead to loading fdt_overlays and applying them, so that fdt_overlays can be expected to Just Work.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kevans created this revision.Dec 28 2017, 2:46 PM
manu added inline comments.Dec 28 2017, 2:52 PM
stand/efi/fdt/efi_fdt.c
52 ↗(On Diff #37136)

if (hdr == NULL)
return (1);

kevans updated this revision to Diff 37137.Dec 28 2017, 2:59 PM

Address manu@'s comment, rework flow to just return early in case of errors.

manu accepted this revision.Dec 28 2017, 3:14 PM
This revision is now accepted and ready to land.Dec 28 2017, 3:14 PM
imp accepted this revision.Dec 28 2017, 4:57 PM
gonzo accepted this revision.Dec 28 2017, 9:12 PM
This revision was automatically updated to reflect the committed changes.