stand/fdt: Avoid bailout when dtbo has no fixups
ClosedPublic
Actions

Authored by kevans on Dec 28 2017, 2:42 PM.

Details

Reviewers

manu
gonzo
imp

Commits

rS327299: stand/fdt: Avoid bailout when dtbo has no fixups

Summary

In the case of a simple dtbo where fragment uses target-path and the overlay contains no references, /__fixups__ will not be included by either our dtc or dtc from ports, but the file still has valid fragments to be applied. My single test fragment:

target-path = "/soc/ethernet";
__overlay__ {
    phy-mode = "rgmii-txid";
};

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 13895

Event Timeline

kevans created this revision.Dec 28 2017, 2:42 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2017, 2:42 PM

kevans retitled this revision from stand/fdt: Fix bailout when dtbo has no fixups to stand/fdt: Avoid bailout when dtbo has no fixups.Dec 28 2017, 2:42 PM

Further testing showed that one of the dt compilers I tried emitted empty /__symbols__ while the other just omitted /__symbols__ since it was empty. I don't know if omitting it is OK according to whatever spec we may follow, but allowing it doesn't seem harmful.

imp accepted this revision.Dec 28 2017, 4:56 PM

This revision is now accepted and ready to land.Dec 28 2017, 4:56 PM

kevans mentioned this in D13659: stand/fdt: Fix loading of multiple fdt_overlays.Dec 28 2017, 9:02 PM

gonzo accepted this revision.Dec 28 2017, 9:08 PM

Closed by commit rS327299: stand/fdt: Avoid bailout when dtbo has no fixups (authored by kevans). · Explain WhyDec 28 2017, 9:12 PM

This revision was automatically updated to reflect the committed changes.