Differential D13145

Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode.
ClosedPublic
Actions

Authored by ed on Nov 18 2017, 1:10 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 2:06 AM

	Unknown Object (File)
	Sat, Nov 2, 4:15 AM

	Unknown Object (File)
	Oct 17 2024, 5:15 PM

	Unknown Object (File)
	Oct 17 2024, 5:15 PM

	Unknown Object (File)
	Oct 17 2024, 5:15 PM

	Unknown Object (File)
	Oct 17 2024, 4:55 PM

	Unknown Object (File)
	Sep 18 2024, 1:51 AM

	Unknown Object (File)
	Sep 5 2024, 5:05 PM

View All 35 Files

Subscribers

Details

Reviewers

manu
andrew

Commits

rS326166: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode.

Summary

Binaries generated by Clang for ARMv6 may contain these instructions:

MCR p15, 0, <Rd>, c7, c10, 5

These instructions are deprecated as of ARMv7, which is why modern
processors have a way of toggling support for them. On FreeBSD/arm64 we
currently disable support for these instructions, meaning that if 32-bit
executables would be run, they would crash with SIGILL. This is likely
not what we want.

Test Plan

This change, and others, allow me to properly run CloudABI
executables for ARMv6 and ARMv7 on FreeBSD/arm64.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed created this revision.Nov 18 2017, 1:10 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptNov 18 2017, 1:10 PM

Harbormaster completed remote builds in B12829: Diff 35408.Nov 18 2017, 1:10 PM

manu added projects: ARM, arm64.Nov 18 2017, 6:37 PM

Are we expecting to run armv6 code, or should we just support armv7?

In D13145#273886, @andrew wrote:

Are we expecting to run armv6 code, or should we just support armv7?

In the case of CloudABI I'd like to run ARMv6 code as well.

andrew accepted this revision.Nov 24 2017, 1:49 PM

This revision is now accepted and ready to land.Nov 24 2017, 1:49 PM

Closed by commit rS326166: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode. (authored by ed). · Explain WhyNov 24 2017, 1:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

arm64/

5 lines

Diff 35691

head/sys/arm64/arm64/locore.S

Loading...