libresonic-standalone's standards.
Needs ReviewPublic
Actions

Authored by jlh on Nov 10 2017, 10:53 PM.

Details

Reviewers

mat
jrm
eadler
sbruno

Summary

www/libresonic-standalone was initially made from www/madsonic-standalone,
which in turn was made from www/subsonic-standalone. It was reviewed in
https://reviews.freebsd.org/D12597 which led to a lot of improvements and
simplifications. This merges those back to www/subsonic-standalone.

Test Plan

vimdiff
make clean all install

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13064
Build 13315: arc lint + arc unit

Event Timeline

jlh created this revision.Nov 10 2017, 10:53 PM

Harbormaster completed remote builds in B12636: Diff 35071.Nov 10 2017, 10:53 PM

jlh added a reviewer: Ports Committers.Nov 12 2017, 8:46 PM

Same here.. does it build in poudriere and do you have the log?

Attached poudriere log file.

subsonic-standalone-standalone-6.0_5.log24 KBDownload

Sync ports tree. Fix a mismerge.

Harbormaster completed remote builds in B12926: Diff 35564.Nov 21 2017, 9:15 PM

Attached poudriere log with fixed mismerge.

subsonic-standalone-6.0_5.log23 KBDownload

The version of the software does not change, you should not do the PORTVERSION -> DISTVERSION change here, but wait for an update that does change the version.

This revision now requires changes to proceed.Nov 24 2017, 6:03 PM

s/DISTVERSION/PORTVERSION/

Harbormaster completed remote builds in B13064: Diff 35786.Nov 25 2017, 9:59 PM

In D13040#275505, @mat wrote:

The version of the software does not change, you should not do the PORTVERSION -> DISTVERSION change here, but wait for an update that does change the version.

Do you mean I ought to make the switch later when the version of the software changes, or that if I want to I can make the switch when the version changes?

jrm added a subscriber: jrm.Apr 8 2018, 2:22 AM

jrm resigned from this revision.Apr 8 2018, 2:27 AM

eadler resigned from this revision.Apr 8 2018, 2:29 AM

sbruno resigned from this revision.Jul 14 2018, 4:21 PM

Is this still relevant? This has been in the Ports Committers review queue for a long time.

tobik removed a reviewer: Ports Committers.Dec 5 2019, 4:30 PM