Add a port for Libresonic.

[jlh]

Summary

This port replicates the existing www/subsonic-standalone and
www/madsonic-standaline. The only difference is that the .war file is provided
directly from the Github project. The .war is not unarchived (as suggested in
the ports handbook) as it conveniently works directly with "java -jar" and I
truss'ed it, it doesn't seem to extract anything but read directly from the war
file.

Test Plan

make all
make install
make deinstall

[jlh]

Fix a "Subsonic" leftover in the description.

[jlh]

Update rc.d script.

[mat]

www/libresonic-standalone/Makefile

4–9 ↗

(On Diff #33730)

PORTNAME=        libresonic
DISTVERSIONPREFIX=  v
DISTVERSION=        6.2
CATEGORIES=        www java
​MASTER_SITES=        https://github.com/Libresonic/libresonic/releases/download/v${DISTVERSION}/
PKGNAMESUFFIX=       -standalone
​EXTRACT_SUFX=        .war

10–13 ↗

(On Diff #33730)

This should happen way way later.

20–31 ↗

(On Diff #33730)

Out of order.

46 ↗

(On Diff #33730)

Not needed.

50–51 ↗

(On Diff #33730)

Happen too late.

58 ↗

(On Diff #33730)

Why += ?

79–85 ↗

(On Diff #33730)

Use ${RLN}

[jlh]

Update diff after mat@'s review.

[jlh]

www/libresonic-standalone/Makefile

4–9 ↗

(On Diff #33730)

Thanks :-). I wanted to stick to what there's in www/madsonic-standalone actually.

10–13 ↗

(On Diff #33730)

Move it below options.

50–51 ↗

(On Diff #33730)

I lifted up next to the first block. I don't know where it's supposed to go. Why is it important, BTW?

[mat]

I don't really understand why you have a pkg-message, and a message-transcoding, and a separator, where they could all be in only one file.

www/libresonic-standalone/Makefile

11 ↗

(On Diff #34385)

missing empty line before.

13 ↗

(On Diff #34385)

Missing empty line before.

50–51 ↗

(On Diff #33730)

To make it easier for anyone to work on any port, there is a standardized way to write things in a Makefile: Chapter 14. Order of Variables in Port Makefiles.

[jlh]

Update diff with mat@'s second review.

[jlh]

Resolve comment

[mat]

www/libresonic-standalone/Makefile

68–73 ↗

(On Diff #34409)

When using a do-install target, don't use a post-install one, put everything in do-install.

[jlh]

Change post-install targets to do-install.

[mat]

www/libresonic-standalone/Makefile

5 ↗

(On Diff #34629)

missing tab after =

58 ↗

(On Diff #34629)

missing tab after =

[jlh]

Add missing tabs.