This port replicates the existing www/subsonic-standalone and
www/madsonic-standaline. The only difference is that the .war file is provided
directly from the Github project. The .war is not unarchived (as suggested in
the ports handbook) as it conveniently works directly with "java -jar" and I
truss'ed it, it doesn't seem to extract anything but read directly from the war
file.
Details
Details
- Reviewers
bapt mat - Commits
- rP453870: Add www/libresonic-standalone port.
make all
make install
make deinstall
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 11908 Build 12241: arc lint + arc unit
Event Timeline
www/libresonic-standalone/Makefile | ||
---|---|---|
5–10 | PORTNAME= libresonic DISTVERSIONPREFIX= v DISTVERSION= 6.2 CATEGORIES= www java MASTER_SITES= https://github.com/Libresonic/libresonic/releases/download/v${DISTVERSION}/ PKGNAMESUFFIX= -standalone EXTRACT_SUFX= .war | |
11–14 | This should happen way way later. | |
21–32 | Out of order. | |
47 | Not needed. | |
51–52 | Happen too late. | |
59 | Why += ? | |
80–86 |
Comment Actions
I don't really understand why you have a pkg-message, and a message-transcoding, and a separator, where they could all be in only one file.
www/libresonic-standalone/Makefile | ||
---|---|---|
12 | missing empty line before. | |
14 | Missing empty line before. | |
51–52 | To make it easier for anyone to work on any port, there is a standardized way to write things in a Makefile: Chapter 14. Order of Variables in Port Makefiles. |
www/libresonic-standalone/Makefile | ||
---|---|---|
69–74 | When using a do-install target, don't use a post-install one, put everything in do-install. |