Page MenuHomeFreeBSD

Add support for Armada 3700 EHCI
ClosedPublic

Authored by mw on Sep 6 2017, 7:31 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Mar 31, 12:58 AM
Unknown Object (File)
Jan 3 2024, 4:56 PM
Unknown Object (File)
Dec 20 2023, 2:15 AM
Unknown Object (File)
Nov 7 2023, 11:59 PM
Unknown Object (File)
Oct 6 2023, 10:49 PM
Unknown Object (File)
Sep 14 2023, 12:45 AM
Unknown Object (File)
Sep 5 2023, 8:10 AM
Unknown Object (File)
Jul 2 2023, 3:22 AM

Details

Summary

This patch reuses ehci_mv driver by adding a support for the new
compatible string and adding ehci_mv.c to list of available options
for arm64 platforms.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was automatically updated to reflect the committed changes.
head/sys/dev/usb/controller/ehci_mv.c
180–181

can we use ofw_bus_search_compatible here, as in D12258?

head/sys/dev/usb/controller/ehci_mv.c
180–181

Actually this code should be executed only for legacy devices using "mrvl,usb-ehci" compatible string, so ofw_bus_search_compatible is imo not sufficient.

Would you like to invert the condition to:

if ((ofw_bus_is_compatible(self, "mrvl,usb-ehci")) {

or can we leave it as-is now?

head/sys/dev/usb/controller/ehci_mv.c
180–181

The ocd_data field returned by ofw_bus_is_compatible() doesn't have to be just true/false. When you've got hardware that has a few small variations, you can use an enum with each compat string (see dev/sdhci/fsl_sdhci.c for an example). You could also do something like a set of bitmapped flags where different flag bits indicate different quirks.