Differential D11935

Mark geom classes as deprecated.
ClosedPublic
Actions

Authored by imp on Aug 9 2017, 2:49 PM.

Tags

None

Referenced Files

	F102959794: D11935.id31822.diff
	Tue, Nov 19, 5:29 AM

	Unknown Object (File)
	Mon, Nov 18, 12:41 AM

	Unknown Object (File)
	Sun, Nov 17, 5:20 PM

	Unknown Object (File)
	Sun, Nov 17, 2:17 PM

	Unknown Object (File)
	Sun, Nov 17, 12:16 PM

	Unknown Object (File)
	Oct 19 2024, 2:39 PM

	Unknown Object (File)
	Oct 15 2024, 12:22 PM

	Unknown Object (File)
	Oct 10 2024, 4:05 AM

View All 61 Files

Subscribers

Details

Reviewers

marcel
jhb
emaste
allanjude
jhibbits

Commits

rS322318: Mark geom classes as deprecated.

Summary

Mark geom classes as deprecated.

geom_bsd, geom_mbr and geom_sunlabel have been obsolete since Marcel
Moolenaar's geom_part was in FreeBSD 7. They haven't been in GENERIC
since FreeBSD 8. Add warning when used.

geom_vol_ffs has been obsolete since ufs support to geom_label was
ncommitted in FreeBSD 5. It hasn't been in GENERIC since FreeBSD 5.
Add warning when used.

geom_fox has been obsolete since gmultipath was committed in FreeBSD 7.
(no warning added, since this is a very obscure class).

These will all be removed in FreeBSD 12.

MFC After 3 days
Differential Revision https://reviews.freebsd.org/D11935

Note Classes will be removed after MFC

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Aug 9 2017, 2:49 PM

Harbormaster completed remote builds in B10969: Diff 31817.Aug 9 2017, 2:49 PM

imp added reviewers: marcel, jhb, emaste.Aug 9 2017, 2:50 PM

allanjude accepted this revision.Aug 9 2017, 3:30 PM

This revision is now accepted and ready to land.Aug 9 2017, 3:30 PM

doIt!

Mark more

This revision now requires review to proceed.Aug 9 2017, 3:44 PM

Harbormaster completed remote builds in B10970: Diff 31821.Aug 9 2017, 3:44 PM

emaste accepted this revision.Aug 9 2017, 3:49 PM

This revision is now accepted and ready to land.Aug 9 2017, 3:49 PM

allanjude accepted this revision.Aug 9 2017, 3:49 PM

More

This revision now requires review to proceed.Aug 9 2017, 4:03 PM

Harbormaster completed remote builds in B10971: Diff 31822.Aug 9 2017, 4:03 PM

imp retitled this revision from Mark geom_bsd, geom_mbr, and geom_sunlabel as deprecated. to Mark geom classes as deprecated..Aug 9 2017, 4:05 PM

imp edited the summary of this revision. (Show Details)

bcr added a subscriber: bcr.Aug 9 2017, 4:05 PM

This comment was removed by bcr.

emaste accepted this revision.Aug 9 2017, 4:08 PM

This revision is now accepted and ready to land.Aug 9 2017, 4:08 PM

Summary updated to be actual commit message with some ':' removed to keep Phab from crying over them.

imp edited the summary of this revision. (Show Details)Aug 9 2017, 4:10 PM

Closed by commit rS322318: Mark geom classes as deprecated. (authored by imp). · Explain WhyAug 9 2017, 4:15 PM

This revision was automatically updated to reflect the committed changes.

Not sure if you could do a runtime warning for GEOM_FOX as well at least?

head/sys/geom/geom_mbr.c
321	FWIW, I would have been fine with whining each time rather than needing a 'once' flag.

In D11935#247749, @jhb wrote:

Not sure if you could do a runtime warning for GEOM_FOX as well at least?

OK. I can do that.

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man4/

25 lines

2 lines

sys/

conf/

10 lines

geom/

8 lines

8 lines

geom_sunlabel.c

8 lines

7 lines

Diff 31823

head/share/man/man4/geom.4

Loading...

head/share/man/man4/geom_fox.4

Loading...

head/sys/conf/NOTES

Loading...

head/sys/geom/geom_bsd.c

Loading...

head/sys/geom/geom_mbr.c

Loading...

head/sys/geom/geom_sunlabel.c

Loading...

head/sys/geom/geom_vol_ffs.c

Loading...