Page MenuHomeFreeBSD

Mark geom classes as deprecated.
ClosedPublic

Authored by imp on Aug 9 2017, 2:49 PM.

Details

Summary

Mark geom classes as deprecated.

geom_bsd, geom_mbr and geom_sunlabel have been obsolete since Marcel
Moolenaar's geom_part was in FreeBSD 7. They haven't been in GENERIC
since FreeBSD 8. Add warning when used.

geom_vol_ffs has been obsolete since ufs support to geom_label was
ncommitted in FreeBSD 5. It hasn't been in GENERIC since FreeBSD 5.
Add warning when used.

geom_fox has been obsolete since gmultipath was committed in FreeBSD 7.
(no warning added, since this is a very obscure class).

These will all be removed in FreeBSD 12.

MFC After 3 days
Differential Revision https://reviews.freebsd.org/D11935

Note Classes will be removed after MFC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Aug 9 2017, 3:30 PM
imp edited edge metadata.

Mark more

This revision now requires review to proceed.Aug 9 2017, 3:44 PM
This revision is now accepted and ready to land.Aug 9 2017, 3:49 PM
imp edited edge metadata.

More

This revision now requires review to proceed.Aug 9 2017, 4:03 PM
imp retitled this revision from Mark geom_bsd, geom_mbr, and geom_sunlabel as deprecated. to Mark geom classes as deprecated..Aug 9 2017, 4:05 PM
imp edited the summary of this revision. (Show Details)
This comment was removed by bcr.
This revision is now accepted and ready to land.Aug 9 2017, 4:08 PM

Summary updated to be actual commit message with some ':' removed to keep Phab from crying over them.

This revision was automatically updated to reflect the committed changes.

Not sure if you could do a runtime warning for GEOM_FOX as well at least?

head/sys/geom/geom_mbr.c
321

FWIW, I would have been fine with whining each time rather than needing a 'once' flag.

In D11935#247749, @jhb wrote:

Not sure if you could do a runtime warning for GEOM_FOX as well at least?

OK. I can do that.