Page MenuHomeFreeBSD

Place the AAD before the plaintext/ciphertext for CIOCRYPTAEAD.
ClosedPublic

Authored by jhb on Jul 27 2017, 9:41 PM.
Tags
None
Referenced Files
F166715168: D11758.diff
Sat, Aug 15, 8:28 PM
Unknown Object (File)
Wed, Aug 12, 4:34 PM
Unknown Object (File)
Tue, Aug 11, 11:33 AM
Unknown Object (File)
Sun, Aug 9, 5:14 AM
Unknown Object (File)
Sun, Aug 9, 2:15 AM
Unknown Object (File)
Sat, Aug 8, 1:12 AM
Unknown Object (File)
Fri, Aug 7, 11:54 PM
Unknown Object (File)
Fri, Aug 7, 10:17 AM

Details

Summary

Place the AAD before the plaintext/ciphertext for CIOCRYPTAEAD.

Software crypto implementations don't care how the buffer is laid out,
but hardware implementations may assume that the AAD is always before
the plain/cipher text and that the hash/tag is immediately after the end
of the plain/cipher text.

In particular, this arrangement matches the layout of both IPSec packets
and TLS frames. Linux's crypto framework also assumes this layout for
AEAD requests.

Test Plan
  • tested IPSec-like requests using the cryptocheck tool against the Chelsio ccr(4) driver and out-of-tree Intel qat(4) driver. Also verified no regressions with aesni0 or cryptosoft
  • note that I hacked ccr(4) to play crazy games with sglists to work around this issue (it will construct a S/G list that places the AAD first), but it is non-ideal as it results in more complicated S/G lists

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable