Limit descriptors in pidfile
ClosedPublic
Actions

Authored by oshogbo on Jul 26 2017, 6:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 2, 8:03 PM

	Unknown Object (File)
	Fri, Nov 29, 7:43 AM

	Unknown Object (File)
	Mon, Nov 25, 11:21 AM

	Unknown Object (File)
	Sun, Nov 24, 3:35 PM

	Unknown Object (File)
	Sun, Nov 24, 1:43 AM

	Unknown Object (File)
	Sat, Nov 23, 7:36 PM

	Unknown Object (File)
	Sat, Nov 23, 11:40 AM

	Unknown Object (File)
	Sat, Nov 23, 7:14 AM

View All Files

Subscribers

None

Details

Reviewers

emaste
allanjude
markj
cem

Commits

rS322370: Limit descriptors stored in the pidfh structure.

Summary

As suggested by markj@ limit descriptors hidden in pidfile.

This review is depending on:
https://reviews.freebsd.org/D11690
https://reviews.freebsd.org/D11692

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

oshogbo created this revision.Jul 26 2017, 6:58 PM

oshogbo edited the summary of this revision. (Show Details)

markj added inline comments.Jul 26 2017, 8:19 PM

lib/libutil/pidfile.c
34	This should come before file.h to maintain a sorted order.
193	Why do we need CAP_SEEK?

oshogbo updated this revision to Diff 31231.Jul 26 2017, 8:29 PM

oshogbo marked an inline comment as done.

oshogbo added inline comments.

lib/libutil/pidfile.c
193	kern_pwritev as us to do so, but insted of CAP_SEEK and CAP_WRITE we can use just CAP_PWRITE which is equvilant.

markj accepted this revision.Jul 26 2017, 8:30 PM

This revision is now accepted and ready to land.Jul 26 2017, 8:30 PM

Style nit: braces seem excessive. Otherwise looks good to me.

Closed by commit rS322370: Limit descriptors stored in the pidfh structure. (authored by oshogbo). · Explain WhyAug 10 2017, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libutil/

pidfile.c

30 lines

Diff 31231

View Options

Limit descriptors in pidfileClosedPublicActions