Store dirfd of pidfile.
ClosedPublic
Actions

Authored by oshogbo on Jul 21 2017, 7:13 PM.

Details

Reviewers

markj
emaste
allanjude

Commits

rS322369: Store directory descriptor in the pidfh structure and use unlinkat(2)

Summary

This allow us to remove pidfile in capability mode thanks to unlinkat(2).

PR: 220524

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Regenerate with -U99999.

markj added inline comments.Jul 23 2017, 7:14 PM

lib/libutil/pidfile.c
133 ↗	(On Diff #31068)	Should we try to limit the rights on this descriptor to CAP_UNLINKAT once the pidfile is open? AFAIK this can be done even if the process is not in capability mode. The cap_rights_limit() man page isn't very clear on this though.
170 ↗	(On Diff #31068)	Seems like we should be careful to preserve errno as you did above?
277 ↗	(On Diff #31068)	The addition of braces here is inconsistent with the if statement above.

Update diff after markj@ review.

oshogbo marked 2 inline comments as done.Jul 25 2017, 8:34 PM

oshogbo added inline comments.

lib/libutil/pidfile.c
133 ↗	(On Diff #31068)	I would like to do that in separate commit, is that fine with you?

Works fine in my testing with your flopenat() patch applied as well.

Thanks for addressing this!

lib/libutil/pidfile.c
252 ↗	(On Diff #31199)	I would kill this blank line.
133 ↗	(On Diff #31068)	Sure.

This revision is now accepted and ready to land.Jul 25 2017, 9:20 PM

Closed by commit rS322369: Store directory descriptor in the pidfh structure and use unlinkat(2) (authored by oshogbo). · Explain WhyAug 10 2017, 4:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libutil/

pidfile.c

77 lines

Diff 31879

View Options

head/lib/libutil/pidfile.c

Store dirfd of pidfile.ClosedPublicActions